docs(design): add the host monorepo design doc - #650
Draft
TarikGul wants to merge 1 commit into
Draft
Conversation
Argues the repository topology so the choice is reviewable before any host moves: one repository with the hosts under `hosts/`, build systems composed rather than merged, and each host building against the in-tree core at HEAD. Names the two rejected alternatives and why. Submodules are the one worth stating explicitly: they look like a cheaper version of the same thing, but a submodule change is a separate commit in a separate repository, so a host referenced that way cannot take part in a single-pull-request check. Records the Gradle composition details confirmed by prototype, including that a composed build is addressed by its directory rather than its rootProject.name, and leaves the three genuinely unresolved questions open rather than answering them here.
Member
Author
|
@lore-bot-app review |
|
Reading the diff and checking what the record says. Back in a few minutes. |
|
Lore couldn't complete this review: Nothing was changed. Try |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Argues the repository topology so the choice is reviewable before any host moves: one repository with the hosts under
hosts/, build systems composed rather than merged, and each host building against the in-tree core at HEAD.Names the two rejected alternatives and why. Submodules are the one worth stating explicitly: they look like a cheaper version of the same thing, but a submodule change is a separate commit in a separate repository, so a host referenced that way cannot take part in a single-pull-request check.
Records the Gradle composition details confirmed by prototype, including that a composed build is addressed by its directory rather than its rootProject.name, and leaves the three genuinely unresolved questions open rather than answering them here.
Design Doc:
Summary
Checklist
docs/design/design-docChanges