fix(cli): supply the persist field on subname registration and sync the v0.7.0 ABIs - #297
Open
filip-parity wants to merge 1 commit into
Open
fix(cli): supply the persist field on subname registration and sync the v0.7.0 ABIs#297filip-parity wants to merge 1 commit into
filip-parity wants to merge 1 commit into
Conversation
CI Summary
Release - PassedTest this PR Download artifact (GitHub CLI required): gh run download 34730637395 -n cli-release-0.0.0-pr.297 -R paritytech/dotns-sdkInstall globally: npm install -g ./parity-dotns-cli-0.0.0-pr.297.tgzVerify: dotns --helpDeploy Example — Passed
Labelspkg: cli, dependencies Test - Passed320 passed, 0 failed across 320 tests. |
…he v0.7.0 ABIs The v0.7.0 registry's SubnodeRecord carries a persist flag deciding whether the subname is indexed into the owner's LabelStore. The CLI never set it: released 0.9.1 fails at encoding (its build-time ABI has the field), and the committed v0.6.0 ABIs miss the new selector entirely. registerSubnode now persists by default with --no-persist to opt out, and the committed ABIs move to the v0.7.0 release, matching the deployed reference chain. Verified on paseo-v2 (v0.7.0): register subname completes and the name resolves with its owner; 0.9.1 fails with 'Invalid boolean value'. Fixes the issuance half of paritytech/dotns#285 (the lite-read half shipped in 0.9.1).
filip-parity
force-pushed
the
fix/285-subnode-persist
branch
from
September 13, 2026 01:29
69ef946 to
dff0e2f
Compare
Member
|
We should make it true by default for public paths only pop names avoid persisting since they dont have runtime limitations and those names eventually settle when the user claims their store via tooling WDYT? |
re-gius
approved these changes
Sep 13, 2026
re-gius
left a comment
re-gius
left a comment
Contributor
There was a problem hiding this comment.
Nit: help/parse coverage exists for register subname, but nothing asserts the encoded SubnodeRecord actually carries persist: true (or false under --no-persist). A small unit test would stop this class of ABI drift from showing up as a runtime encode error again.
Otherwise LGTM
Contributor
My take: this path is signed CLI register subname, so persist correctly stays on by default. PoP already skips persist in the controller and the user claims the store later, so I'm fine with the current status of this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Two things the v0.7.0 registry needs that the CLI doesn't do:
SubnodeRecordgained apersistflag (index the subname into the owner's Label Store, or write only the record). The code never set it, so released 0.9.1 dies at encoding withInvalid boolean value: "undefined".registerSubnodenow persists by default,--no-persistopts out.setSubnodeOwnerselector no longer exists on the deployed chain — synced to v0.7.0. (npm builds resync at release time, which is why 0.9.1's failure was the encode rather than a revert.)Covers the issuance half of paritytech/dotns#285; the lite-read half shipped in 0.9.1.
Type
Package
@parity/dotns-cliTesting
Live on paseo-v2 (v0.7.0):
register subname -n vzerosub -p filipverifyninezerocompletes (tx0xc5b80088…) andlookup name vzerosub.filipverifyninezeroresolves with its owner. Same command on 0.9.1 fails at encoding. 320 unit tests, typecheck, lint green.Version bumped to 0.9.2 for the release guard.