fix(cli): resolve lite names on both node schemes - #293
Closed
filip-parity wants to merge 1 commit into
Closed
Conversation
dotns v0.7.0 issues a lite name as a subname beneath its numeric container, which is exactly the per-label fold; older deployments and names minted before an in-place upgrade keep the whole dotted label hashed flat under the TLD. The registry says which applies: domainNode uses the folded node when it has a record and falls back to the legacy node otherwise, so both generations resolve on the same chain. Verified on paseo-v2 (upgraded to v0.7.0 tonight): a freshly attested lite name resolves at its folded node with this change and reads as not-registered on 0.9.0. Fixes paritytech/dotns#299
CI Summary
Labelspkg: cli, type: test |
re-gius
approved these changes
Sep 11, 2026
re-gius
left a comment
re-gius
left a comment
Contributor
There was a problem hiding this comment.
LGTM - we can publish this as v0.9.1 since it's not breaking backward compatibility
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Stacked on #291 (per-label folding). dotns v0.7.0 — live on paseo since last night — issues a lite name as a subname beneath its numeric container, which is exactly the per-label fold. Older deployments, and names minted before an in-place upgrade, keep the whole dotted label hashed flat. Since the controller ABI is identical between v0.6.0 and v0.7.0 there is nothing to probe, so
domainNodeasks the registry: folded node if it has a record, legacy flat node otherwise. Both generations resolve on the same chain, and unregistered lite names still read as unregistered everywhere.Type
Package
@parity/dotns-cliFixes
Fixes paritytech/dotns#299
Testing
Unit tests cover the fold, the legacy fallback, and the unregistered case (320 pass). Live on paseo-v2 v0.7.0: attested a fresh lite name (
filipvzerocheck.42) through the gateway — this branch resolves it at the folded node with its owner; released 0.9.0 reports it not-registered. Its container42appeared owned by the PopController, as the contracts describe.truapi is unaffected: it never derives lite nodes (string paths only) — checked while scoping.