test(polkavm): fit framebuffer within the drawable surface - #217
Closed
replghost wants to merge 1 commit into
Closed
test(polkavm): fit framebuffer within the drawable surface#217replghost wants to merge 1 commit into
replghost wants to merge 1 commit into
Conversation
replghost
requested review from
BigTava,
Cyr06130,
KarimJedda,
ba1uev,
justraman,
leonardocustodio and
tallesborges
as code owners
September 9, 2026 01:19
Contributor
⚡ Performance Report
|
Contributor
Bundle Size ReportChunks over 500 KB:
All files
Commit: cb70a7b |
Collaborator
Author
Contributor
|
The truapi-host CLI could not complete pairing (testnet chains or Logs: https://github.com/paritytech/dotli-community/actions/runs/34298719194 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #216. Test-only correction; deliberately no deployment label and no change to the live westendli.dev build.
The Functional failure in run 34288688806 expected canvas top=75 but observed 60.5 because the host input/status strip now occupies space below the drawable surface. The prior assertions also assumed the framebuffer filled the entire iframe height on resize.
Replace incidental fixed coordinates with the observable contract: the 320x200 framebuffer preserves aspect ratio, maximally fits, and is centered within its actual drawable surface, across three viewport shapes. Keep verified launch, translation/cache reload and pointer-lock teardown assertions.
Verification:
No production source or behavior changed.