Stop the empty login error box leaving a gap above the fields - #199
Merged
Merged
Conversation
The box started as `invisible`, which hides a view but keeps its height, so before any sign-in had failed there was a blank band between the title and the fields. It had been there quietly; putting the Export logs button inside the box in #197 made it tall enough to notice. It now starts `gone`, which is the state the code already assumes: the only two toggles are VISIBLE on a failure and GONE on success. Height is `wrap_content` rather than `match_parent`, the same mistake #184 fixed in the device list row. The test asserts GONE specifically. `not(isDisplayed())` is equally true of an invisible view and would have passed against the gap - it is the check the Export logs test already makes, and it said nothing about this. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reported by @parawanderer from the 1.1.0 test build: a blank band between the title and the sign-in fields.
login_error_containerstarted asinvisible, which hides a view but keeps its height. It had always reserved a line's worth of space; #197 put the Export logs button inside it, which made the reserved space tall enough to notice.Fix
gonerather thaninvisible— the state the code already assumes, since the only two toggles areVISIBLEon a failure andGONEon successlayout_height="wrap_content"rather thanmatch_parent, the same mistake Fix the device list row clipping its subtitle line #184 fixed in the device list rowTest
theemptyErrorBoxTakesNoRoomBeforeAnythingHasFailedasserts effective visibilityGONE.not(isDisplayed())is equally true of an invisible view and would have passed against the gap — it is the check #197's test already made, and it said nothing about this.Not verified red against the old layout by a separate CI run: the old XML declares
invisible, which Espresso reports asINVISIBLE, so theGONEmatcher fails on it deterministically rather than on timing.🤖 Generated with Claude Code