Skip to content

realign_score: model tag v2; read length check in check-realign-scoring.py - #324

Merged
AndreaGuarracino merged 1 commit into
mainfrom
fix/realign-model-v2
Nov 15, 2026
Merged

AndreaGuarracino merged 1 commit into
mainfrom
fix/realign-model-v2

Conversation

@AndreaGuarracino

Copy link
Copy Markdown
Member

Model tag: since #304, E uses the reads' declared length instead of 150. Outputs for reads of another length changed (148 bp HG002 pilot: E moves 0.0020 nat at Q30) but kept the name anchor-realign-diplotype-calls-v1. It is now -v2. No code in the repo compares this string; it is a label in the output manifest.

Check script: genome/instrumented/check-realign-scoring.py assumes 150 bp reads in 13 places (its dataset). Before it re-derives E, it now checks that impg's declared scoring.read_length is that length, so a run on other reads reports the length, not an E mismatch.

@ekg: tell me if anything outside the repo matches on the v1 tag.

…; check script fails clearly on reads of another length
@AndreaGuarracino
AndreaGuarracino merged commit 46290e0 into main Nov 15, 2026
3 checks passed
@AndreaGuarracino
AndreaGuarracino deleted the fix/realign-model-v2 branch November 15, 2026 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant