Repository navigation
realign_score: model tag v2; read length check in check-realign-scoring.py - #324
Merged
Merged
Conversation
…; check script fails clearly on reads of another length
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Model tag: since #304, E uses the reads' declared length instead of 150. Outputs for reads of another length changed (148 bp HG002 pilot: E moves 0.0020 nat at Q30) but kept the name
anchor-realign-diplotype-calls-v1. It is now-v2. No code in the repo compares this string; it is a label in the output manifest.Check script:
genome/instrumented/check-realign-scoring.pyassumes 150 bp reads in 13 places (its dataset). Before it re-derives E, it now checks that impg's declaredscoring.read_lengthis that length, so a run on other reads reports the length, not an E mismatch.@ekg: tell me if anything outside the repo matches on the v1 tag.