BUG: Improve error message when ExtensionDtype subclass missing 'name' attribute#65299
Open
avasis-ai wants to merge 1 commit intopandas-dev:mainfrom
Open
BUG: Improve error message when ExtensionDtype subclass missing 'name' attribute#65299avasis-ai wants to merge 1 commit intopandas-dev:mainfrom
avasis-ai wants to merge 1 commit intopandas-dev:mainfrom
Conversation
When an ExtensionDtype subclass does not define a 'name' class attribute, construct_from_string would fail with an unhelpful AssertionError. Replace with a clear TypeError that names the subclass and explains the requirement.
Member
|
Does this need a test? Does this address the comments in the motivating issue? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #46093
When an
ExtensionDtypesubclass does not define anameclass attribute (or defines it as a non-string),construct_from_stringwould fail with an unhelpfulAssertionError: (<class '__main__.FooType'>, <class 'property'>).This replaces the
assert isinstance(cls.name, str)with a properTypeErrorthat clearly names the subclass and explains that thenameattribute must be a string class attribute.