Repository navigation
Move the file list and Settings navigator into components directories - #466
Merged
Merged
Conversation
caffold-file-list was registered in the file navigator's private directory and caffold-settings-navigator beside the Settings layout, outside the components/ directories that hold Web Component entry points. Both move with their stylesheets and tests; markup and behavior are unchanged. The placement contract now checks all frontend JavaScript instead of only Tasks.
🚀 Deploying Preview to Cloudflare 🚀Preview URL: https://component-placement-caffold.taehoon-moon.workers.dev (commit 97f2e58)This URL reflects your latest Preview deploymentPreview Deployments by commit
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
caffold-file-listandcaffold-settings-navigatorwere registered outside thecomponents/directories that hold Web Component entry points, and the placement contract checked only Tasks, so neither was caught.caffold-file-listmoves tocomponents/file-navigator/components/list.js, with its stylesheet and unit test.caffold-settings-navigatormoves tosettings/components/navigator.js, with its stylesheet, unit test, and private item component, matching the Tasks and Notes navigators.frontend/, with no exceptions.Closes #464