Repository navigation
Fix Review showing Git changes read before the page came back - #465
Merged
Merged
Conversation
After the page or Review came back, the scope on screen kept its old list until the reread finished, and the other scope was never read again, so Branch could keep saying "No changes" after new commits. Choosing a scope now reads data from before the return again, places that said nothing changed show loading or the read's error meanwhile, and a reread reloads the open diff, source, or preview in place.
The Review layout read Working Tree status, the Branch compare, and the open file itself. Each now has its own component with the read state after a return as an explicit model, and the layout keeps the route, selection, and Git watch. Retrying a failed Branch reread now shows loading in the viewer instead of the last error, and Working Tree's loading text is not redrawn when another reread starts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the browser page came back to the foreground or Review was opened again, the list on screen kept what it had read before until its reread finished, and the other list was never read again. Branch could keep saying "No changes compared with origin/main." after new commits.
components/git-compare-tree.js.frontend.mddescribes the new components and the reread after a return.Closes #461