Repository navigation
Fix app updates downloading every file after the browser drops its cache - #459
Merged
Merged
Conversation
A new build's service worker filled its shell cache with cache.addAll, so an unchanged file was kept only while the browser's HTTP cache still held it; once Chrome dropped those copies, the next update downloaded all 26 MB again. It now asks about each file with the tag of the copy in an earlier build's cache and keeps that copy when the server answers that it is unchanged.
🚀 Deploying Preview to Cloudflare 🚀Preview URL: https://reuse-shell-cache-on-update-caffold.taehoon-moon.workers.dev (commit 878ef1c)This URL reflects your latest Preview deploymentPreview Deployments by commit
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After a day or two without an update, Chrome can drop the copies it kept of Caffold's app files, and the next update then downloaded every one of them again: 26.6 MB, mostly fonts. On a slow phone link that took minutes, and replies queued behind it on the same connection waited long enough for the live connection to stall and show Reconnecting.
/and the manifest, which carry no tag.