Repository navigation
Fix the Composer stuttering with large pictures attached - #458
Merged
Merged
Conversation
With a few large pictures attached, the Composer stuttered, voice input and its spinner included. Every render rebuilt the thumbnails and the voice and send buttons from markup, and each thumbnail drew the whole photo into its 72px box. Attachments now have their own strip that keeps a node per attachment and draws a picture from a copy 216px on its short side; the Composer's buttons stay mounted and only what changed is patched.
🚀 Deploying Preview to Cloudflare 🚀Preview URL: https://composer-incremental-render-caffold.taehoon-moon.workers.dev (commit 49b6726)This URL reflects your latest Preview deploymentPreview Deployments by commit
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With a few large pictures attached, the Composer stuttered: voice input, its spinner, and its level meter jerked, and the Composer froze for a moment at each voice step.
Web:
Docs:
frontend.mdlists the attachment strip and describes how its thumbnails are drawn.