Skip to content

don't use kwargs for get_or_abort - #34

Merged
davidism merged 1 commit into
mainfrom
args
Nov 13, 2025
Merged

don't use kwargs for get_or_abort#34
davidism merged 1 commit into
mainfrom
args

Conversation

@davidism

Copy link
Copy Markdown
Member

Rather than accepting **kwargs in get_or_abort and one_or_abort, take a get_kwargs and execute_kwargs instead. This makes it clearer what args belong to the method or what is passed on, and matches abort_kwargs. get_or_abort takes options, as it's very common to pass that argument to session.get to load relationships; similar to the code arg for abort.

@davidism davidism added this to the 0.2.0 milestone Nov 13, 2025
@davidism
davidism merged commit 56ebf7a into main Nov 13, 2025
9 checks passed
@davidism
davidism deleted the args branch November 13, 2025 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant