update test isolation pattern - #26
Merged
Merged
Conversation
This was referenced Nov 1, 2025
Member
Author
|
#32 adds a context manager to do this instead of needing to copy all that code from the docs. It will be part of 0.2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
join_transaction_mode="create_savepoint"tells the SQLAlchemy session to use nested savepoints. The docs mention tests as one reason to use this: https://docs.sqlalchemy.org/en/20/orm/session_api.html#sqlalchemy.orm.Session.params.join_transaction_modeengine.connectis patched to return the existing connection.connection.closeis patched to do nothing.connection.beginis patched to callbegin_nestedinstead, since it's already in a transaction for the test.After experimenting a bunch with a debugger, these were the minimal additional changes I found were needed. I'll look into adding a function to manage this instead of needing to copy from the docs.
closes #19, closes #20