Fix VoiceTrigger placement for Android < 16#1
Conversation
- Introduced `VoiceTriggerFixPlugin` to move VoiceTrigger from `/product` to `/system_ext` on Android < 16. - Enhanced `SystemModifier` for backward compatibility by adding missing methods and stubs. - Registered `VoiceTriggerFixPlugin` in `UnifiedModifier` and the plugin registry. - Verified with existing and new test cases. Co-authored-by: palazik <257841280+palazik@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
This change fixes a bug where VoiceTrigger was incorrectly placed on older Android versions. It introduces a modular
VoiceTriggerFixPluginthat handles moving the VoiceTrigger application from the/productpartition to/system_extwhen the base Android version is less than 16.To maintain compatibility with existing tests that mock internal
SystemModifiermethods, backward compatibility methods (stubs and proxies) were added to theSystemModifierclass inunified_modifier.py.The new plugin is automatically discovered and executed by the
UnifiedModifiersystem. All tests, including the specializedtest_voice_trigger.py, pass successfully.PR created automatically by Jules for task 5991654330523645076 started by @palazik