Skip to content

Fix VoiceTrigger placement for Android < 16#1

Open
palazik wants to merge 1 commit into
mainfrom
fix-voice-trigger-placement-5991654330523645076
Open

Fix VoiceTrigger placement for Android < 16#1
palazik wants to merge 1 commit into
mainfrom
fix-voice-trigger-placement-5991654330523645076

Conversation

@palazik

@palazik palazik commented Mar 20, 2026

Copy link
Copy Markdown
Owner

This change fixes a bug where VoiceTrigger was incorrectly placed on older Android versions. It introduces a modular VoiceTriggerFixPlugin that handles moving the VoiceTrigger application from the /product partition to /system_ext when the base Android version is less than 16.

To maintain compatibility with existing tests that mock internal SystemModifier methods, backward compatibility methods (stubs and proxies) were added to the SystemModifier class in unified_modifier.py.

The new plugin is automatically discovered and executed by the UnifiedModifier system. All tests, including the specialized test_voice_trigger.py, pass successfully.


PR created automatically by Jules for task 5991654330523645076 started by @palazik

- Introduced `VoiceTriggerFixPlugin` to move VoiceTrigger from `/product` to `/system_ext` on Android < 16.
- Enhanced `SystemModifier` for backward compatibility by adding missing methods and stubs.
- Registered `VoiceTriggerFixPlugin` in `UnifiedModifier` and the plugin registry.
- Verified with existing and new test cases.

Co-authored-by: palazik <257841280+palazik@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant