Skip to content

[SELC-9178] IAM: Removed productId, tenantId from ProductRolePermissionsList - #769

Merged
gaetano-miglionico merged 2 commits into
mainfrom
feature/SELC-9178
Aug 25, 2026
Merged

[SELC-9178] IAM: Removed productId, tenantId from ProductRolePermissionsList#769
gaetano-miglionico merged 2 commits into
mainfrom
feature/SELC-9178

Conversation

@gaetano-miglionico

Copy link
Copy Markdown
Contributor

This pull request introduces support for a new tenantId parameter across the IAM API documentation, backend service logic, and related tests. The main focus is to make the tenantId available in API requests and ensure it is consistently passed through service layers and tested throughout the codebase.

API Documentation Updates:

  • Added a tenantId field to relevant request and response schemas in both api-iam-docs.json and api-docs.json, ensuring the OpenAPI specs reflect the new parameter. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]

  • Updated endpoint definitions to accept tenantId as an optional query parameter, with a default value of "AR". [1] [2] [3] [4] [5] [6] [7]

Backend Service Changes:

  • Modified all calls to iamExternalRestClient._getIAMProductRolePermissionsList and iamRestClient._hasIAMUserPermission to include the tenantId parameter, defaulting to "AR". This ensures tenant context is always passed to IAM permission checks and role queries. [1] [2] [3] [4] [5] [6]

Testing Updates:

  • Updated unit tests to include the tenantId parameter in all relevant mock and verification calls, ensuring test coverage for the new logic. [1] [2] [3] [4] [5] [6] [7] [8]

Other Minor Changes:

  • Minor property order and formatting adjustments in the OpenAPI JSON files for consistency. [1] [2] [3] [4]
  • Removed an unused import in ExchangeTokenServiceV2.java.

Summary of Most Important Changes:

API Schema and Endpoint Enhancements:

  • Added tenantId as a property and query parameter in relevant OpenAPI schemas and endpoints, with a default value of "AR". [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]

Backend Service Logic:

  • Updated all service and client calls to IAM permission and role APIs to include the new tenantId parameter, ensuring tenant-aware authorization logic. [1] [2] [3] [4] [5] [6]

Testing:

  • Modified and extended test cases to mock and verify the new tenantId parameter in all relevant IAM client calls. [1] [2] [3] [4] [5] [6] [7] [8]

Code Cleanup:

  • Removed an unused import from ExchangeTokenServiceV2.java.

Schema Consistency:

  • Adjusted property order and formatting in OpenAPI files for consistency and clarity. [1] [2] [3] [4]

@sonarqubecloud

Copy link
Copy Markdown

@gaetano-miglionico
gaetano-miglionico merged commit 31f0def into main Aug 25, 2026
51 checks passed
@gaetano-miglionico
gaetano-miglionico deleted the feature/SELC-9178 branch August 25, 2026 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants