Skip to content

chore: properly handle null values in remote presentation startFlowFromQR - #385

Open
gispada wants to merge 3 commits into
masterfrom
presentation-qr-validation
Open

chore: properly handle null values in remote presentation startFlowFromQR#385
gispada wants to merge 3 commits into
masterfrom
presentation-qr-validation

Conversation

@gispada

@gispada gispada commented Sep 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

List of Changes

  • Strip null values from the QR code parameters to validate, default request_uri_method to get
  • Added tests
  • Replaced deprecated Zod string().url() with url()

Motivation and Context

This PR makes startFlowFromQR more tolerant with null or missing optional values in the QR code payload of remote presentations.

How Has This Been Tested?

Screenshots (if appropriate):

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@gispada
gispada requested a review from a team as a code owner September 2, 2026 12:32
@github-actions github-actions Bot added the chore label Sep 2, 2026
ale-mazz
ale-mazz approved these changes Sep 3, 2026
View reviewed changes

@ale-mazz ale-mazz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ale-mazz ale-mazz ale-mazz approved these changes
@manuraf manuraf Awaiting requested review from manuraf manuraf is a code owner automatically assigned from pagopa/io-wallet
@LazyAfternoons LazyAfternoons Awaiting requested review from LazyAfternoons LazyAfternoons is a code owner automatically assigned from pagopa/io-wallet

Assignees

No one assigned

Labels

chore

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gispada @ale-mazz