Stop treating EPEL 10 specially - #518
Conversation
|
Build succeeded. ✔️ pre-commit SUCCESS in 2m 08s |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines the CI/CD configuration by removing special handling for EPEL 10. Previously, EPEL 10 had its own dedicated package definition and explicit job configurations across various stages like COPR builds, tests, and downstream proposals. These changes integrate EPEL 10 as a standard target within the existing, more generalized job definitions, simplifying the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request simplifies the Packit configuration by removing the special handling for EPEL 10 and consolidating its jobs with the main Fedora/EPEL configurations. This is a good cleanup. I've found a couple of inconsistencies in how the jobs for koji_build and bodhi_update are handled. Specifically, it seems Bodhi updates for EPEL 10 will be disabled, which might be unintentional. Please see my detailed comments.
I am having trouble creating individual review comments. Click here to see my feedback.
.packit.yaml (284-287)
This change removes the bodhi_update job for EPEL 10, but epel-10-all is not added to any other bodhi_update job. This will effectively disable Bodhi updates for EPEL 10. If this is not intentional, epel-10-all should be added to the dist_git_branches of the main &bodhi_update job to ensure Bodhi updates are created for EPEL 10 releases.
.packit.yaml (257-260)
This koji_build job for EPEL 10 is removed, but epel-10-all is later added to a specific koji_build job, not the main one that handles fedora-all and epel-9. For consistency with how other jobs (copr_build, tests, etc.) are updated in this PR, epel-10-all should be added to the dist_git_branches of the main &koji_build job definition. This would make the configuration more consistent and easier to maintain.
|
/packit build |
|
/packit-stg build |
Signed-off-by: Nikola Forró <nforro@redhat.com>
|
Build succeeded. ✔️ pre-commit SUCCESS in 2m 06s |
|
/packit retest-failed |
|
/packit-stg retest-failed |
1 similar comment
|
/packit-stg retest-failed |
|
/packit retest-failed |
|
Build succeeded (gate pipeline). ✔️ pre-commit SUCCESS in 2m 27s |
Related with packit#518
3 participants
Merge after packit/packit#2694.