Skip to content

Document the added support of identifier with OSH jobs #1168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
betulependule wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Document the added support of identifier with OSH jobs #1168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions docs/configuration/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -844,6 +844,14 @@ Additionally, the target branch of the pull request must match the branch specif
the configuration for that job. For more details on setting up such a job, refer to
[this documentation](/docs/configuration/upstream/copr_build.md).

:::caution Multiple OSH jobs
Comment thread
betulependule marked this conversation as resolved.

If `osh_diff_scan_after_copr_build` is enabled and you have multiple Copr build jobs with the `pull_request` trigger, each will trigger its own OSH differential scan.
To ensure each scan compares against the right base build, assign matching `identifier` values to each `pull_request`-triggered job and its corresponding `commit`-triggered job.
If identifiers are missing or don't match, Packit falls back to the first `commit`-triggered job configured for that branch — which can mean multiple scans end up comparing against the same (possibly wrong) base build.

:::

:::info
This functionality is an initial prototype and both configuration and functionality
will likely change in the future.
Expand Down
1 change: 1 addition & 0 deletions docs/configuration/upstream/copr_build.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,7 @@ With this configuration, you'll get builds in all stable fedora releases
* **identifier** - Suffix added to the name of a GitHub check run.
For example if you [set this to "mock"](https://github.com/rpm-software-management/mock/pull/902/checks?check_run_id=6530714905), then a check run for Rawhide would be
named "rpm-build:fedora-rawhide-x86\_64:mock".
Additionally, this option has uses in relation to [Testing Farm](/docs/configuration/upstream/tests#optional-parameters) and [OpenScanHub](/docs/configuration#osh_diff_scan_after_copr_build) jobs.
:::caution
Make sure to configure this option if you are having multiple `copr_build` jobs in the configuration,
otherwise the reporting may be incorrect.
Expand Down
Loading