Skip to content

Fix MRTarget equality to compare branch values #3175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rgetz wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix MRTarget equality to compare branch values #3175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packit_service/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ def __eq__(self, other: object) -> bool:
if not isinstance(other, MRTarget):
raise NotImplementedError()

return self.repo == other.repo and self.branch == self.branch
return self.repo == other.repo and self.branch == other.branch


class ServiceConfig(Config):
Expand Down
8 changes: 8 additions & 0 deletions tests/unit/test_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,14 @@ def test_parse_valid(service_config_valid):
assert config.package_config_path_override is None


def test_mr_target_membership_respects_branch(service_config_valid):
config = ServiceConfig.get_from_dict(service_config_valid)
assert MRTarget("redhat/centos-stream/src/.+", "c9s") in config.gitlab_mr_targets_handled
assert (
MRTarget("redhat/centos-stream/src/.+", "rawhide") not in config.gitlab_mr_targets_handled
)


def test_parse_optional_values(service_config_valid):
"""When optional values are set, they are correctly parsed"""
config = ServiceConfig.get_from_dict(
Expand Down
Loading