Skip to content

Sanitize spec files - #3047

Merged
centosinfra-prod-github-app[bot] merged 1 commit into
packit:mainfrom
nforro:sanitization
Mar 11, 2026
Merged

Sanitize spec files#3047
centosinfra-prod-github-app[bot] merged 1 commit into
packit:mainfrom
nforro:sanitization

Conversation

@nforro

@nforro nforro commented Mar 9, 2026

Copy link
Copy Markdown
Member

Merge after packit/specfile#519.

@nforro
Sanitize spec files
e4a962d 
Signed-off-by: Nikola Forró <nforro@redhat.com>
@nforro nforro moved this from New to In review in Packit pull requests Mar 9, 2026
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Mar 9, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the sanitize=True parameter to the Specfile constructor within IsRunConditionSatisfied.pre_check. This change aligns with the PR's objective to sanitize spec files, likely by adopting a new feature from the specfile library. The implementation is correct, and I have no further suggestions.

Note: Security Review did not run due to the size of the PR.

@centosinfra-prod-github-app

centosinfra-prod-github-app Bot commented Mar 9, 2026

Copy link
Copy Markdown
Contributor

Build succeeded.
https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/packit-service/buildset/0d2ef345a4494175b950bea8f11918fa

✔️ pre-commit SUCCESS in 1m 48s
✔️ packit-service-tests SUCCESS in 4m 16s

@nforro nforro added the mergeit Merge via Zuul label Mar 11, 2026
@centosinfra-prod-github-app

centosinfra-prod-github-app Bot commented Mar 11, 2026

Copy link
Copy Markdown
Contributor

Build succeeded (gate pipeline).
https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/packit-service/buildset/cc5da6816b4b4f7bbf89950589faadfb

✔️ pre-commit SUCCESS in 1m 52s

@centosinfra-prod-github-app
centosinfra-prod-github-app Bot merged commit b40ddb2 into packit:main Mar 11, 2026
6 checks passed
@github-project-automation github-project-automation Bot moved this from In review to Done in Packit pull requests Mar 11, 2026
@nforro
nforro deleted the sanitization branch March 11, 2026 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lbarcziova lbarcziova lbarcziova approved these changes
+1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

mergeit Merge via Zuul

Projects

Packit pull requests
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nforro @lbarcziova @usercont-release-bot