Add non-default feature flag 'profiling' to xde#1022
Merged
Conversation
This feature flag is off by default, and can only be enabled by manually editing xde/Cargo.toml. It makes it possible to conditionally disable inlining and name mangling on functions of interest. In particular, it has been applied to xde_rx_one and xde_mc_tx_one. While there are probes that serve as proxies for these functions, it is still valuable to be able to probe them directly while working locally. $ dtrace -l | grep "xde_.*x_one entry" fbt xde xde_rx_one entry fbt xde xde_mc_tx_one entry Should this workflow become frequently used, it can be made available in the build xtask, but this is a larger project for later, if at all. Signed-off-by: Daniel Levin <daniel.levin@oxidecomputer.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This feature flag is off by default, and can only be enabled by manually editing xde/Cargo.toml. It makes it possible to conditionally disable inlining and name mangling on functions of interest. In particular, it has been applied to xde_rx_one and xde_mc_tx_one. While there are probes that serve as proxies for these functions, it is still valuable to be able to probe them directly while working locally.
Should this workflow become frequently used, it can be made available in the build xtask, but this is a larger project for later, if at all.