Added a file accessibility check to addFile - #16
Open
senderic wants to merge 1 commit into
Open
Conversation
I was back and forth on this idea, as throwing an error has its merits, but since we are adding files within a JSON array, if a file is not accessible, giving a `console.error(..)` prompt and not breaking flows better for me. Potentially options can be added so throw exceptions if that is more desired by the end user?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was back and forth on this idea, as throwing an error has its merits, but since we are adding files within a JSON array, if a file is not accessible, giving a
console.error(..)prompt and not breaking flows better for me.Potentially options can be added so throw exceptions if that is more desired by the end user?