Repository navigation
test(allocator): cover local growth ledger regressions - #574
Closed
shipiyouniao wants to merge 1 commit into
Closed
shipiyouniao wants to merge 1 commit into
shipiyouniao wants to merge 1 commit into
Conversation
shipiyouniao
force-pushed
the
fix/local-physical-reservation
branch
2 times, most recently
from
October 15, 2026 06:04
3b82768 to
d5c3570
Compare
Co-authored-by: 石皮幼鸟 <2960474346@qq.com>
shipiyouniao
force-pushed
the
fix/local-physical-reservation
branch
from
October 19, 2026 05:07
d5c3570 to
27dd583
Compare
shipiyouniao
changed the title
shipiyouniao
marked this pull request as ready for review
October 19, 2026 06:50
This was referenced Oct 19, 2026
Collaborator
Author
|
The tests from this PR have been moved into #455 as the independent commit 2cc3240, preserving authorship. #488 and #489 inherit that commit through #455 rather than duplicating the tests. The three updated heads passed private CPU, native GPU, C++, pre-commit and type checks, plus all nine PR CI checks each. Closing this PR because its test coverage now travels with #455; no PR was merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#574 is now tests-only on main after #487 absorbed the local reservation implementation and device guard.
The retained regressions cover local
alloc_pageaccounting across page sizes, layouts and buffer counts; reuse of an already mapped offset without another charge; two independent CUDA processes competing under one shared instance limit while preserving the winner's data; and reserve/map failures that preserve existing pages, refund failed growth and permit retry.No production code or admission mechanism is added. The old release-failure expectation is omitted because main retains ownership through its quarantine handling.
Validation at
27dd583: rebuilt native extension on one T4, 83 passed / 3 cross-device skips; Python 3.11 CPU suite, 1,492 passed / 15 skipped; C++ tests, all-file pre-commit and strict MyPy 3.11 passed. Dedicated Codex review found no actionable defects. The remaining Python runtime matrix is checked by PR CI. No new performance or full-model serving result is claimed.