fix: recover from transient reply failures - #242
Open
FrundlesTian wants to merge 2 commits into
Open
FrundlesTian wants to merge 2 commits into
FrundlesTian wants to merge 2 commits into
Conversation
|
No issues found that should block merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Prevent intermittent Telegram requests from finishing without a delivered reply.
NetworkError/TimedOutfailures with bounded exponential backoffBadRequestfailures are not retriedResultMessagegetUpdatesclient with the explicit proxyThis is stacked on #236 and currently includes #240 (
4f62dc2). The connection-stability implementation is commit0b8c8e2; once #240 lands, this branch can be rebased without changing the fix.Related issue
Closes #241
Type of change
How it was tested
pytest -q— 690 passedblack --check src testsisort --check-only src testsflake8 src testsThe regression tests cover transient recovery, retry exhaustion, permanent
BadRequest, empty SDK EOF recovery, partial-stream non-replay, and proxy wiring for both PTB clients.Checklist
CHANGELOG.mdhas an entry under[Unreleased]