Skip to content

support progress bars in gurt.download while using GURT:// - #117

Merged
face-hh merged 9 commits into
outpoot:mainfrom
someoneidoknow:main
Sep 28, 2025
Merged

face-hh merged 9 commits into
outpoot:mainfrom
someoneidoknow:main

Conversation

@someoneidoknow

Copy link
Copy Markdown
Contributor

title
please merge....

@Hassunaama

Copy link
Copy Markdown

lol

@someoneidoknow

Copy link
Copy Markdown
Contributor Author
image

@face-hh
face-hh requested a review from Copilot September 26, 2025 14:09

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds progress bar support for downloads using the GURT:// protocol by implementing streaming download capabilities with real-time progress callbacks. The changes extend the existing download functionality to handle GURT protocol downloads with progress tracking similar to HTTP downloads.

Key changes:

  • Added streaming request functionality to the GURT client with progress callbacks
  • Implemented download event system with progress tracking for the Godot extension
  • Updated download manager to use the new streaming GURT download approach

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
tests/download.html Adds test case for GURT protocol downloads with new button and documentation
protocol/library/src/message.rs Introduces GurtResponseHead struct for streaming response headers
protocol/library/src/lib.rs Exports the new GurtResponseHead struct in public API
protocol/library/src/error.rs Adds Cancelled error variant for download cancellation
protocol/library/src/client.rs Implements stream_request method with head and chunk callbacks for progress tracking
protocol/gdextension/src/lib.rs Adds download event system with progress signals and streaming support
flumi/Scripts/Browser/NetworkRequest.gd Improves byte formatting to handle GB sizes properly
flumi/Scripts/Browser/DownloadManager.gd Replaces blocking GURT downloads with streaming approach using progress callbacks

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread protocol/library/src/client.rs Outdated
Comment thread protocol/library/src/client.rs Outdated
Comment thread protocol/gdextension/src/lib.rs
Comment thread protocol/gdextension/src/lib.rs Outdated
Comment thread tests/download.html
someoneidoknow and others added 2 commits September 26, 2025 15:13
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

@Smartlinuxcoder Smartlinuxcoder left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This adds changes on how downloads are handled and adds a new error type, client version should be bumped

@someoneidoknow

Copy link
Copy Markdown
Contributor Author

fair point

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread protocol/library/src/client.rs Outdated
Comment thread flumi/Scripts/Browser/DownloadManager.gd
Comment thread flumi/Scripts/Browser/DownloadManager.gd
@face-hh

face-hh commented Sep 28, 2025

Copy link
Copy Markdown
Member

@someoneidoknow could you resolve the first two nitpicks from mr copilot, excluding the last one

someoneidoknow and others added 2 commits September 28, 2025 17:12
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@face-hh
face-hh merged commit acfc3b4 into outpoot:main Sep 28, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants