Repository navigation
support progress bars in gurt.download while using GURT:// - #117
Conversation
|
lol |
There was a problem hiding this comment.
Pull Request Overview
This PR adds progress bar support for downloads using the GURT:// protocol by implementing streaming download capabilities with real-time progress callbacks. The changes extend the existing download functionality to handle GURT protocol downloads with progress tracking similar to HTTP downloads.
Key changes:
- Added streaming request functionality to the GURT client with progress callbacks
- Implemented download event system with progress tracking for the Godot extension
- Updated download manager to use the new streaming GURT download approach
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/download.html | Adds test case for GURT protocol downloads with new button and documentation |
| protocol/library/src/message.rs | Introduces GurtResponseHead struct for streaming response headers |
| protocol/library/src/lib.rs | Exports the new GurtResponseHead struct in public API |
| protocol/library/src/error.rs | Adds Cancelled error variant for download cancellation |
| protocol/library/src/client.rs | Implements stream_request method with head and chunk callbacks for progress tracking |
| protocol/gdextension/src/lib.rs | Adds download event system with progress signals and streaming support |
| flumi/Scripts/Browser/NetworkRequest.gd | Improves byte formatting to handle GB sizes properly |
| flumi/Scripts/Browser/DownloadManager.gd | Replaces blocking GURT downloads with streaming approach using progress callbacks |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Smartlinuxcoder
left a comment
There was a problem hiding this comment.
This adds changes on how downloads are handled and adds a new error type, client version should be bumped
|
fair point |
There was a problem hiding this comment.
Pull Request Overview
Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
@someoneidoknow could you resolve the first two nitpicks from mr copilot, excluding the last one |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

title
please merge....