Skip to content
This repository was archived by the owner on May 22, 2026. It is now read-only.

allow stop test speaker#592

Open
romainlq wants to merge 2 commits into
ottomated:masterfrom
romainlq:feature/allow-stop-test-speaker
Open

allow stop test speaker#592
romainlq wants to merge 2 commits into
ottomated:masterfrom
romainlq:feature/allow-stop-test-speaker

Conversation

@romainlq

@romainlq romainlq commented Jan 20, 2021

Copy link
Copy Markdown

I added the possibility to stop the test speaker as soon as it started playing.

Closes #591

@OhMyGuus

OhMyGuus commented Jan 22, 2021

Copy link
Copy Markdown
Contributor

You should add:
audio.onended = () => { setPlaying(false); };
Because u forgot to reset the button when the sound stopped, for the rest nice.

@romainlq

Copy link
Copy Markdown
Author

thanks for the feedback @OhMyGuus !
It has been fixed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow to stop test speaker

2 participants