Drop unused sonic-yang-mgmt dependency#2327
Merged
Merged
Conversation
The sonic-yang-mgmt git dependency was added in #2191 for the original libyang-based SONiC config validator. #2253 replaced that validator with offline-generated Pydantic schemas and cleaned up requirements.txt, requirements.sonic.txt and the Containerfile, but left the dependency behind in Pipfile/Pipfile.lock. Nothing imports sonic_yang_mgmt anymore (the runtime validator depends only on pydantic, and the schema generator uses pyang), so remove it from both files and refresh the Pipfile hash. AI-assisted: Claude Code Signed-off-by: Christian Berendt <berendt@osism.tech>
osfrickler
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes the
sonic-yang-mgmtgit dependency fromPipfileandPipfile.lock.Why
sonic-yang-mgmtwas added in #2191 for the original libyang-based SONiC config validator. #2253 replaced that validator with offline-generated Pydantic schemas and cleaned uprequirements.txt,requirements.sonic.txtand theContainerfile— but left the dependency behind inPipfile/Pipfile.lock.Nothing imports
sonic_yang_mgmtanymore:pydantic(seeosism/tasks/conductor/sonic/validator.py)tools/sonic_yang_to_pydantic.py) usespyang, which staysIt was also the only git dependency in the lockfile.
Notes
Pipfile.lock_metahash was recomputed with pipenv's owncalculate_pipfile_hash()so the lockfile stays in sync with the Pipfile.pyangis intentionally kept — it is required by the schema generator.🤖 Generated with Claude Code