Skip to content

Add sonic port_config file for DellEMC-S5212f-P-25G#2325

Merged
berendt merged 1 commit into
mainfrom
add-dell-hwsku
Jun 2, 2026
Merged

Add sonic port_config file for DellEMC-S5212f-P-25G#2325
berendt merged 1 commit into
mainfrom
add-dell-hwsku

Conversation

@osfrickler
Copy link
Copy Markdown
Member

No description provided.

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The DellEMC-S5212f-P-25G.ini port map skips logical ports (e.g. Ethernet13–15 and 17–19); please confirm this numbering matches the actual SONiC SKU and hardware layout expectations for this platform.
  • There are trailing spaces and inconsistent alignment in the new DellEMC-S5212f-P-25G.ini entries (e.g. after speeds), which can be cleaned up to match the formatting style of existing port_config files.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The `DellEMC-S5212f-P-25G.ini` port map skips logical ports (e.g. Ethernet13–15 and 17–19); please confirm this numbering matches the actual SONiC SKU and hardware layout expectations for this platform.
- There are trailing spaces and inconsistent alignment in the new `DellEMC-S5212f-P-25G.ini` entries (e.g. after speeds), which can be cleaned up to match the formatting style of existing port_config files.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Add a list of supported vendors and make the unit test check against
that vendor list.

Signed-off-by: Dr. Jens Harbott <harbott@osism.tech>
@osfrickler osfrickler moved this from Ready to In review in Human Board Jun 2, 2026
@berendt berendt requested a review from ideaship June 2, 2026 15:33
@berendt berendt merged commit 1646353 into main Jun 2, 2026
3 checks passed
@berendt berendt deleted the add-dell-hwsku branch June 2, 2026 20:35
@github-project-automation github-project-automation Bot moved this from In review to Done in Human Board Jun 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants