Add sonic port_config file for DellEMC-S5212f-P-25G#2325
Merged
Conversation
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The
DellEMC-S5212f-P-25G.iniport map skips logical ports (e.g. Ethernet13–15 and 17–19); please confirm this numbering matches the actual SONiC SKU and hardware layout expectations for this platform. - There are trailing spaces and inconsistent alignment in the new
DellEMC-S5212f-P-25G.inientries (e.g. after speeds), which can be cleaned up to match the formatting style of existing port_config files.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The `DellEMC-S5212f-P-25G.ini` port map skips logical ports (e.g. Ethernet13–15 and 17–19); please confirm this numbering matches the actual SONiC SKU and hardware layout expectations for this platform.
- There are trailing spaces and inconsistent alignment in the new `DellEMC-S5212f-P-25G.ini` entries (e.g. after speeds), which can be cleaned up to match the formatting style of existing port_config files.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
fe19810 to
9a2bb23
Compare
Add a list of supported vendors and make the unit test check against that vendor list. Signed-off-by: Dr. Jens Harbott <harbott@osism.tech>
9a2bb23 to
abaebb4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.