chore: delete osac-metering repository - #190
Open
masayag wants to merge 1 commit into
Open
Conversation
Work consolidated into the osac mono-repo; osac-metering never received any commits, so it is dead weight. Remove the Terraform module (and the now-orphaned moved block) so the next apply deletes the repository. The common_repository module does not set archive_on_destroy, so removing the module permanently deletes the repo rather than archiving it. This is intentional given the repo is empty. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Signed-off-by: Moti Asayag <masayag@redhat.com>
|
Important Review available on request
Reviews should be triggered manually for repositories with fewer than 10 stars. Select Trigger review above or comment ⚙️ Run configurationConfiguration used: Repository: osac-project/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the
osac-meteringTerraform module so the nexttofu applydeletes theosac-meteringGitHub repository.Rationale: work has been consolidated into the
osacmono-repo, andosac-meteringnever received any commits — it's an empty repository and pure dead weight.Changes
module "repo_osac_metering"block fromrepositories.tf.movedblock that pointedrepo_osac_metering_service→repo_osac_metering(leaving it would reference a non-existent module and failtofu validate).modules/common_repositorydoes not setarchive_on_destroy, so removing the module makes Terraform/OpenTofu permanently delete the repository rather than archive it. This is intentional here because the repo is empty. (This differs from previously consolidated repos such asfulfillment-serviceandosac-operator, which were archived because they contained history worth preserving.)Reviewers: please confirm the repo is genuinely empty before merging.
🤖 Generated with Claude Code