Git via SSH: Replace Jsch transport with Apache - #948
Closed
amberin wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
Intended to solve #904 |
Contributor
Author
|
Rebased on current master. |
This was referenced Aug 31, 2022
N.B. Requires API >= 26. Apache MINA SSHD is now the standard SSH transport library for JGit. It supports more modern key algorithms than Jsch. I have added a notification prompt to the user upon new or unexpected SSH server host key. I have no idea what I'm doing, but it seems to work.
Contributor
Author
|
Closing this in favor of #1037. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apache MINA SSHD is now the standard SSH transport library for JGit. It supports more modern key algorithms than Jsch. This is my implementation attempt. It uses a .ssh directory in the app's private storage for storing "known hosts" information.
I hope to look into generating the SSH private key on the device shortly.
I have added a notification prompt to the user upon new or changed SSH server host key. I am probably doing this completely wrong, but it seems to work.
N.B. Currently requires API >= 26, but I suspect that would be easy to fix for someone who actually knows Java and Android.