Fix off-by-one that leaves one stale point in the graph buffer#580
Open
chatman-media wants to merge 1 commit into
Open
Fix off-by-one that leaves one stale point in the graph buffer#580chatman-media wants to merge 1 commit into
chatman-media wants to merge 1 commit into
Conversation
drain(0..idx) skips the element at idx, but idx is the index of the last point that's actually older than the buffer window (it matched the filter right above). So every update() call quietly leaves exactly one out-of-window sample sitting in the data, forever. Switched it to drain(0..=idx) and added a test that seeds a few stale/fresh points and checks nothing older than the window survives after update().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PlotData::updatetrims points older than the buffer window by finding the index of the last stale entry and draining0..idx. Butidxitself matched the "is stale" filter, so it never actually gets removed — every call leaves exactly one out-of-window point sitting indata. It's subtle since it's always just one point and gets re-evaluated on the next tick, but it means the graph (and the min/max bounds computed from it) is never quite trimmed to what--buffersays it should be.Changed the drain to
0..=idxand added a test that seeds a mix of stale/fresh timestamps directly and checks none of the stale ones surviveupdate().