Skip to content

⚡ Bolt: Replace .filter().collect() with manual loop and preallocated Vec in children_of - #163

Open
ovasylenko wants to merge 1 commit into
mainfrom
bolt/optimize-children-of-589442603582692870
Open

⚡ Bolt: Replace .filter().collect() with manual loop and preallocated Vec in children_of#163
ovasylenko wants to merge 1 commit into
mainfrom
bolt/optimize-children-of-589442603582692870

Conversation

@ovasylenko

Copy link
Copy Markdown
Contributor

💡 What: Replaced the .filter(...).collect() iterator chain in orch8-engine/src/evaluator.rs:children_of with a manual for loop pushing to a Vec instantiated with Vec::with_capacity(8).

🎯 Why: Because .collect() on a filter adapter doesn't know the final size in advance, it starts with a capacity of 0 (or a very small allocation) and reallocates memory as items are pushed. Pre-allocating a small baseline capacity skips these initial reallocation overheads in an execution hot path called repeatedly during state evaluation.

📊 Impact: Reduces memory reallocation overheads in a heavily used function.

🔬 Measurement: Verified by ensuring all tests pass via cargo test -p orch8-engine --lib evaluator::tests.


PR created automatically by Jules for task 589442603582692870 started by @ovasylenko

… Vec in children_of

Co-authored-by: ovasylenko <3797513+ovasylenko@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant