Skip to content

🛡️ Sentinel: [HIGH] Fix IDOR in bulk instance endpoints #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ovasylenko merged 1 commit into from
Sep 20, 2026
+17 −1
Merged

🛡️ Sentinel: [HIGH] Fix IDOR in bulk instance endpoints #155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions orch8-api/src/instances/bulk.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,14 @@ fn metadata_filter(filter: &BulkFilter) -> Option<serde_json::Value> {
)]
pub async fn bulk_update_state(
State(state): State<AppState>,
admin_ctx: crate::auth::OptionalAdmin,
tenant_ctx: crate::auth::OptionalTenant,
Json(req): Json<BulkUpdateStateRequest>,
) -> Result<impl IntoResponse, ApiError> {
let scoped_tenant = crate::auth::scoped_tenant_id(&tenant_ctx, req.filter.tenant_id.as_deref());
if tenant_ctx.is_none() {
crate::api_keys::require_admin(&admin_ctx)?;
}
if scoped_tenant.is_none() {
return Err(ApiError::InvalidArgument(
"bulk operations require a tenant_id".into(),
Expand Down Expand Up @@ -72,10 +76,14 @@ pub async fn bulk_update_state(
)]
pub async fn bulk_reschedule(
State(state): State<AppState>,
admin_ctx: crate::auth::OptionalAdmin,
tenant_ctx: crate::auth::OptionalTenant,
Json(req): Json<BulkRescheduleRequest>,
) -> Result<impl IntoResponse, ApiError> {
let scoped_tenant = crate::auth::scoped_tenant_id(&tenant_ctx, req.filter.tenant_id.as_deref());
if tenant_ctx.is_none() {
crate::api_keys::require_admin(&admin_ctx)?;
}
if scoped_tenant.is_none() {
return Err(ApiError::InvalidArgument(
"bulk operations require a tenant_id".into(),
Expand Down Expand Up @@ -112,10 +120,14 @@ pub async fn bulk_reschedule(
)]
pub async fn list_dlq(
State(state): State<AppState>,
admin_ctx: crate::auth::OptionalAdmin,
tenant_ctx: crate::auth::OptionalTenant,
Query(q): Query<ListQuery>,
) -> Result<impl IntoResponse, ApiError> {
let scoped_tenant = crate::auth::scoped_tenant_id(&tenant_ctx, q.tenant_id.as_deref());
if tenant_ctx.is_none() {
crate::api_keys::require_admin(&admin_ctx)?;
}
let filter = InstanceFilter {
tenant_id: scoped_tenant,
namespace: q.namespace.map(Namespace::new),
Expand Down Expand Up @@ -153,10 +165,14 @@ pub async fn list_dlq(
)]
pub async fn batch_action(
State(state): State<AppState>,
admin_ctx: crate::auth::OptionalAdmin,
tenant_ctx: crate::auth::OptionalTenant,
Json(req): Json<BatchActionRequest>,
) -> Result<impl IntoResponse, ApiError> {
let scoped_tenant = crate::auth::scoped_tenant_id(&tenant_ctx, req.filter.tenant_id.as_deref());
if tenant_ctx.is_none() {
crate::api_keys::require_admin(&admin_ctx)?;
}
let Some(tenant_id) = scoped_tenant else {
return Err(ApiError::InvalidArgument(
"batch actions require a tenant_id".into(),
Expand Down
2 changes: 1 addition & 1 deletion orch8-api/src/mcp_server.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -426,7 +426,7 @@ async fn tool_list_dlq(state: AppState, tenant_ctx: OptionalTenant, args: &Value
query.insert("limit".into(), json!(limit));
}
let q: crate::instances::ListQuery = parse_args(Value::Object(query))?;
rest_json(crate::instances::list_dlq(State(state), tenant_ctx, Query(q)).await).await
rest_json(crate::instances::list_dlq(State(state), None, tenant_ctx, Query(q)).await).await
}

/// `get_usage`: tenant-scoped LLM token/cost aggregation over a time window.
Expand Down
Loading