Skip to content
This repository was archived by the owner on Apr 6, 2022. It is now read-only.
This repository was archived by the owner on Apr 6, 2022. It is now read-only.

Refactor Slack Messages API #501

Description

@caillou

The Slack messages API is currently inconsistent.

// packages/slack/lib/publish.js
publish()
postMessage()

The publish() and postMessages() mehtods in https://github.com/orbiting/backends/blob/master/packages/slack/lib/publish.js do not return promises, nor do any of the methods in https://github.com/orbiting/backends/blob/master/packages/republik/lib/slack.js.

Yet, most of the code relies on these methods returning promises.

There is an attempt at refactoring the code here: 4ef98c2

Yet, the questions remains open, if these methods should return promises at all.

It is event questionable, if the Slack API should be used in our code, or if we should just log to the console and react to it separately.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions