fix(deps): override transitive adm-zip and sharp to patched versions - #2513
Open
carlos-alm wants to merge 1 commit into
Open
fix(deps): override transitive adm-zip and sharp to patched versions#2513carlos-alm wants to merge 1 commit into
carlos-alm wants to merge 1 commit into
Conversation
Both are pulled in transitively via the optional @huggingface/transformers dev dependency (onnxruntime-node -> adm-zip, and transformers -> sharp), and their upstream caret ranges exclude the patched releases. Force resolution to adm-zip@^0.6.0 (GHSA-xcpc-8h2w-3j85) and sharp@^0.35.3 (GHSA-f88m-g3jw-g9cj) via npm overrides. docs check acknowledged: dependency version bump only, no feature/architecture/language changes.
Contributor
Greptile SummaryThis PR overrides two vulnerable transitive development dependencies with patched releases and updates the lockfile accordingly.
Confidence Score: 5/5The PR appears safe to merge, with no concrete blocking or non-blocking defects identified. The overrides resolve the vulnerable transitive packages, the updated sharp engine requirement remains below the repository’s Node.js minimum, and no reachable dependency incompatibility was established. Important Files Changed
Reviews (1): Last reviewed commit: "fix(deps): override transitive adm-zip a..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@huggingface/transformersdev dependency:adm-zip< 0.6.0 (GHSA-xcpc-8h2w-3j85, high) — ZIP central-directory size field is trusted without bounds checking, allowing a ~120-byte crafted ZIP to trigger a ~4GB allocation (DoS). Pulled in viaonnxruntime-node.sharp< 0.35.0 (GHSA-f88m-g3jw-g9cj, high) — inherited libvips vulnerabilities (CVE-2026-33327/33328/35590/35591). Pulled in directly by@huggingface/transformers.^0.5.16,^0.34.5) that exclude the patched releases even at the latest@huggingface/transformers@4.2.0, so annpm overridesentry is the correct fix rather than bumping a direct dependency.Test plan
npm ls adm-zip sharpshows both resolved to the overridden patched versions with no ERESOLVE issuesnpm auditno longer reports either CVEnpm testsuite passes clean (328/328 files, 5285 passed) after rebuilding the native addon anddist/in this fresh worktreenpm run lintclean