Conversation
openwrt
Bot
added
not following guidelines
release/25.12
3 tasks
Backport the modemmanager hotplug noise reduction from master. On every boot and hotplug replay each net/tty/wwan uevent is handed to mm_report_event via the hotplug scripts, which log an info "event processed" line to daemon.info before mm_report_event decides whether the device is relevant. On a target with SQM tunnels, bridges and veth that is dozens of pointless info lines per boot. In addition, procd replays every uevent before /etc/init.d/modemmanager starts, so the live mmcli --report-kernel-event call fails with "couldn't get bus" and is logged as daemon.err per modem port. Make mm_report_event the single authority on what is worth reporting: it now returns non-zero when it drops a virtual device (keeping the QMAP/ QMI/MBIM multiplexing netdevices qmapmux*/qmimux*/mbimmux*, which are virtual but are real modem data ports) and returns success when it caches an event for a not-yet-running ModemManager. The hotplug scripts only emit their "event processed" info log when the event was actually reported. The live mmcli call is skipped while ModemManager is down; the wrapper replays the cache once it is up. This combines the master commits below into a single change; the intermediate /devices/virtual guard of 7885dff, which wrongly dropped the mux data ports, is superseded by the mm_report_event based filtering and is therefore not applied on its own. (cherry picked from commit 187382d) (cherry picked from commit f094afb) Signed-off-by: Michael Pfeifroth <micpf@westermo.com>
micpf
force-pushed
the
mm-2512-noise
branch
from
September 22, 2026 09:01
05cd58f to
4d15ca6
Compare
openwrt-ai
reviewed
Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of the modemmanager hotplug noise reduction to
openwrt-25.12, as requested in #30571.Context
On master this landed as three commits:
187382d9d14— modemmanager: skip live report when the service isn't up yet7885dff933e7— modemmanager: skip virtual net devices in hotplug scriptf094afbed0e8— modemmanager: suppress hotplug noise without breaking QMAP/QMI/MBIM mux (modemmanager: suppress hotplug noise without breaking QMAP/QMI/MBIM mux #30571)openwrt-25.12never received any of them, so it still emits the per-device"event processed"info line for every virtual net device (bridges, veth, SQM IFB, GRE, tun/tap, ...) and adaemon.errper modem port when the livemmcli --report-kernel-eventruns before ModemManager is up.Note the QMAP/QMI/MBIM regression fixed by #30571 does not exist on 25.12, because the commit that caused it (
7885dff933e7, the blanket/devices/virtual/* exit) was never backported. This PR therefore brings the noise reduction only, in its final mux-safe form.Change
Squashed into a single commit to avoid landing the intermediate buggy
7885dff933e7step on a release branch.mm_report_event()becomes the single authority:qmapmux*/qmimux*/mbimmux*),net,tty,wwan) only log"event processed"when the event was actually reported,mmclicall is skipped while MM is down (the wrapper replays from cache).The resulting
net/modemmanagerfiles are byte-for-byte identical to master.PKG_RELEASEbumped 10 → 11.Maintainer checklist
modemmanager:PKG_RELEASEbumped