Conversation
flatstik
marked this pull request as draft
September 15, 2026 02:22
openwrt-ai
reviewed
Sep 15, 2026
openwrt-ai
left a comment
openwrt-ai
left a comment
Collaborator
There was a problem hiding this comment.
Commit checks
13657fa"luci-app-veracrypt: add optional LuCI UI" — "with passwords on stdin" holds only for the current password;--new-password=,--protection-password=and--token-pin=are built into the argv at lines 897/908/917 ofluci.veracryptand are visible inps. Reword to say the current password goes on stdin, and qualify the same claim inREADME.md:9.
Generated by Claude Code
flatstik
marked this pull request as ready for review
September 21, 2026 12:06
flatstik
force-pushed
the
luci-app-veracrypt
branch
2 times, most recently
from
September 21, 2026 12:34
1f3dc93 to
5dc1ef3
Compare
Author
|
The commit-check about |
openwrt-ai
reviewed
Sep 21, 2026
flatstik
force-pushed
the
luci-app-veracrypt
branch
from
September 21, 2026 17:42
5dc1ef3 to
0f7f9a3
Compare
openwrt-ai
reviewed
Sep 22, 2026
flatstik
force-pushed
the
luci-app-veracrypt
branch
from
September 22, 2026 09:53
0f7f9a3 to
41d7fb4
Compare
Web UI for the console veracrypt package (packages feed): openwrt/packages#30508 Not bundled into veracrypt; apk add luci-app-veracrypt depends on +veracrypt. Calls veracrypt --text only. The current password is passed on stdin (--stdin), never --password. New password, hidden volume password and token PIN are fed on stdin, not via --new-password, --protection-password or --token-pin. CLI reference: https://www.veracrypt.fr/en/Command%20Line%20Usage.html Signed-off-by: Ville Takio <ville+git@takio.fi>
flatstik
force-pushed
the
luci-app-veracrypt
branch
from
September 22, 2026 12:31
41d7fb4 to
b9138ba
Compare
openwrt-ai
reviewed
Sep 22, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Optional LuCI UI for console VeraCrypt. Not bundled into the
veracryptpackage.Depends on the packages-feed CLI: openwrt/packages#30508
apk add luci-app-veracryptpulls+veracryptveracrypt --textonly (no VeraCrypt GUI toolkit)--stdin), never--password--new-password/--protection-password/--token-pinCLI reference: https://www.veracrypt.fr/en/Command%20Line%20Usage.html