luci-app-ha-cluster: add LuCI interface - #8549
pgaufillet wants to merge 1 commit into
Conversation
openwrt-ai
left a comment
openwrt-ai
left a comment
There was a problem hiding this comment.
Reviewed the new luci-app-ha-cluster package (1 commit, fresh review). The commit message matches its changes. Inline comments cover one likely form-submit bug in the owsync chip widget and a few naming/dead-code nits. The backend dependency on the unmerged ha-cluster package (openwrt/packages#29137) is correctly disclosed in the PR description.
Generated by Claude Code
Add a LuCI web interface for the ha-cluster package. Pages: - General: simple form for 2+ router HA configuration - Status: real-time cluster state, peer health, sync statistics - Advanced: keepalived tuning, owsync groups, lease-sync settings 5 JavaScript views (~1700 lines), rpcd backend (~490 lines). Follows standard LuCI patterns (form maps, poll-based status, ACL). Depends on: ha-cluster (openwrt/packages) Signed-off-by: Pierre Gaufillet <pierre.gaufillet@bergamote.eu>
5d20399 to
cb859dc
Compare
| o = s.option(form.DummyValue, '_dhcp_leases', _('Real-time DHCP Lease Sync')); | ||
| o.rawhtml = true; | ||
| o.cfgvalue = function() { | ||
| return '<em>' + _('Install the <code>lease-sync</code> and <code>dnsmasq-ha</code> packages to enable real-time DHCP lease synchronization.') + '</em>' + |
There was a problem hiding this comment.
Which package provides dnsmasq-ha? It is not a variant in package/network/services/dnsmasq/Makefile on openwrt main (only dnsmasq, dnsmasq-dhcpv6, dnsmasq-full), and it is not named in this PR's dependency list, so users following this hint may not find anything to install. Same text at lease-sync-advanced.js:26.
Generated by Claude Code
| - VRRP instance management (VIPs grouped by instance fail over atomically) | ||
| - Virtual IP (VIP) configuration per interface with instance selector | ||
| - Inline VRRP instance creation from VIP modal ("Add new..." option) |
There was a problem hiding this comment.
nit: these three bullets describe a General tab that no longer exists — the VIP section hardcodes a single main instance (simple.js:401-422)`` and its own description tells users to go to the Advanced page for independent failover groups; there is no instance selector and no "Add new..." option.
| - VRRP instance management (VIPs grouped by instance fail over atomically) | |
| - Virtual IP (VIP) configuration per interface with instance selector | |
| - Inline VRRP instance creation from VIP modal ("Add new..." option) | |
| - Virtual IP (VIP) configuration per interface (single shared failover group) |
Generated by Claude Code
This branch has not been deployed
2 participants
Add a LuCI web interface for the ha-cluster package.
Pages:
5 JavaScript views (~1700 lines), rpcd backend (~490 lines).
Follows standard LuCI patterns (form maps, poll-based status, ACL).
Part of the OpenWrt HA cluster proposal:
Depends on: ha-cluster (openwrt/packages#29137)