Repository navigation
Conversation
…osal template; deviation comments rule Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019LJvVaoT3vhaJj7k9LBzEn
A dataset or dictionary with bytes that are not valid UTF-8 and carry no latin1 declaration stopped the check script before the report was written (trimws, tolower, nchar and gsub raise "input string N is invalid"). Three packages of the September sweep hit this: gdho, wsabrazil and washinvestments. The script now counts such values per character column from the data as loaded, then replaces each invalid byte with "?" in the copy the scans read. A new advisory line per dataset names the columns and the rows affected. The existing UTF-8 line keeps naming every non-UTF-8 column. Text files and the header of a historical data file go through the same replacement, so a line with an invalid byte is matched instead of skipped with a warning. The case invalid-utf8 plants the bytes through an R script, so no file with invalid bytes is tracked. The pkgreviewtest report gains one PASS line. The 19 FAIL and 1 FLAG mapping to D1 to D17 is unchanged. Assisted-by: Claude claude-fable-5-1
Patch release for the check script fix of #86. No checklist item changed, so there is no reconciliation section. Assisted-by: Claude claude-fable-5-1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pkgreview-check.Rbefore the report is written. The invalid values are counted from the data as loaded and the scans read a copy with those bytes replaced.fixtures/cases/invalid-utf8/. The expected report forpkgreviewtestgains one PASS line, and the 19 FAIL plus 1 FLAG mapping to D1 to D17 is unchanged.bash scripts/release.sh 1.6.1frommain.Closes #86
Test plan
bash scripts/lint.shis cleanbash fixtures/run_gate.shmatches both expected reportsbash fixtures/run_cases.shpasses all nine cases, includinginvalid-utf8bash scripts/news_section.sh 1.6.1prints the 1.6.1 section