Port to xcffib - #1868
Draft
user202729 wants to merge 1 commit into
Draft
Port to xcffib#1868user202729 wants to merge 1 commit into
user202729 wants to merge 1 commit into
Conversation
Member
Author
|
Build failure is puzzling. I'd expect a import failure but...?
Edit: looks like transient failure, passes now. |
user202729
force-pushed
the
xcffib-port
branch
2 times, most recently
from
September 19, 2026 04:20
ceffbfc to
d7a1dd1
Compare
Member
Author
|
Fixed LLM hallucinations and tested by hand the keyboard capture/uncapture part. I'm not entirely sure what the wmctrl part is about (tests done on a window manager that doesn't support that feature, so it returns None…?), but it at least doesn't error out. Second force-push is to fit code in (restrictive) 80-column limit. Update: wmctrl also manually (programmatically) tested now. |
user202729
marked this pull request as ready for review
September 19, 2026 04:25
user202729
marked this pull request as draft
September 19, 2026 04:25
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires tych0/xcffib#205 . DO NOT MERGE until new xcffib version available.
Though, as mentioned in that pull request, it might be possible to use
xkbcommoninstead, which Plover already depends on.Summary of changes
Delete dependency on python-xlib, depend on xcffib instead.
Reason: python-xlib is not very active nowadays, and it has a few bugs/missing features that I come across.
With a nontrivial amount of LLM assistance. Changes look relatively mechanical (some magic constants come from
X11/X.hthatxcffibdoesn't include, such as tych0/xcffib#206), but I should test it first.Pull Request Checklist