WINC-1971: [ote] Migrate proxy tests from OTP to OTE - #4459
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@rrasouli: This pull request references WINC-1971 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
|
Important Review skippedAuto reviews are limited based on label configuration. 🚫 Review skipped — only excluded labels are configured. (2)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
openshift-ci
Bot
added
approved
beb86e3 to
56219a8
Compare
openshift-ci
Bot
added
approved
56219a8 to
53cef9c
Compare
rrasouli
changed the title
3e52c58 to
dc2052b
Compare
dc2052b to
beb86e3
Compare
openshift-ci
Bot
added
needs-rebase
|
@rrasouli: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Migrated 6 proxy tests (65980, 90290, 90289, 66670, 68320, 71173) from openshift-tests-private to OTE framework. All tests passing on vSphere proxy cluster. Key changes: - Fixed getWMCOTimestamp() to use name= label instead of app= - Added waitForWICDConfigMapUpdate() and waitForWICDConfigMapContains() - Fixed checkUserCertificatesOnNodes() to poll internally - Improved HostProcess pod polling (5s → 1s interval) - Added restoreProxyEnvironment() logging for better debugging Test modifications: - Test 71173: Removed LB traffic test (vSphere incompatible, not proxy-related) - Test 90289: Added workaround for WMCO bug (doesn't remove env vars from ConfigMap) - Tests > 13 min tagged with Longduration and [Slow] All tests verified passing with proper cleanup and error handling.
beb86e3 to
267db37
Compare
openshift-ci
Bot
removed
the
needs-rebase
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rrasouli The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
2 participants
Migrates 6 proxy tests from OTP to OTE framework and registers a dedicated proxy test suite.
What's Changed
Files:
ote/test/e2e/proxy.go- 6 proxy tests migrated from OTPote/test/e2e/utils.go- 24 proxy utility functionsote/cmd/wmco-tests-ext/main.go- Registeredwindows-machine-config-operator/proxysuiteTests migrated:
Fixes:
isProxy()andwaitForProxyStatus()checks from BeforeEach (per OTE team feedback)[node-proxy]qualifier for CI filteringRunning Tests Locally
Build the binary:
cd ote GOWORK=off go build -o ../build/_output/bin/wmco-tests-ext ./cmd/wmco-tests-ext/Option 1: Run individual test (recommended for local testing)
KUBECONFIG=/path/to/kubeconfig ../build/_output/bin/wmco-tests-ext run-test \ -n '[OTP][sig-windows] Windows_Containers Smokerun-Author:rrasouli-Critical-65980-[node-proxy]-Cluster-wide proxy settings validation [Serial]'Option 2: Run full suite (use in CI)
# Note: Use -o jsonl for streaming output. Default -o json buffers until suite completes. KUBECONFIG=/path/to/kubeconfig ../build/_output/bin/wmco-tests-ext run-suite windows-machine-config-operator/proxy \ -o jsonl \ -c 1 \ -j ./junit-proxy.xmlList available tests:
CI Integration
windows-machine-config-operator/proxy/test vsphere-proxy-e2e-oteipi-vsphere-ovn-hybrid-custom-vxlan-port-proxyKnown Issues
OCPBUGS-111093: WMCO doesn't remove proxy env vars from WICD ConfigMap when removed from cluster proxy spec. Test 90289 includes workaround (skips WICD ConfigMap verification for httpsProxy removal).
Related: