NO-ISSUE: Disable 5.1 ushift periodics - #83246
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@pacevedom: This pull request explicitly references no jira issue. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
WalkthroughThe MicroShift 5.1 periodic job schedules now run on June 6. Existing execution times and weekday filters remain unchanged. ChangesMicroShift periodic schedules
Estimated code review effort: 1 (Trivial) | ~3 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
openshift-ci
Bot
added
the
approved
|
[REHEARSALNOTIFIER]
The following jobs are not rehearsable without the
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/config/openshift/microshift/openshift-microshift-release-5.1__periodics.yaml`:
- Line 56: Replace the changed periodic cron schedules, including the one shown
under the release scheduling configuration, with the repository’s
impossible-date parking pattern such as 0 4 31 2 *. Apply this consistently to
all changed schedules and run make update afterward.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 51fcb6d9-0b8d-459b-8afb-fb1eb351b373
⛔ Files ignored due to path filters (1)
ci-operator/jobs/openshift/microshift/openshift-microshift-release-5.1-periodics.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (1)
ci-operator/config/openshift/microshift/openshift-microshift-release-5.1__periodics.yaml
| - intranet | ||
| - nested-podman | ||
| cron: 0 4 * * 1-5 | ||
| cron: 0 4 * 6 1-5 |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -eu
file='ci-operator/config/openshift/microshift/openshift-microshift-release-5.1__periodics.yaml'
printf '%s\n' '--- target cron entries ---'
rg -n '^[[:space:]]+cron:' "$file"
printf '%s\n' '--- nearby job definitions ---'
sed -n '1,360p' "$file"
printf '%s\n' '--- repository parking schedules ---'
rg -n -i 'cron:|impossible|park|disable' ci-operator/config | rg -i 'cron:|impossible|park|disable' | head -200
printf '%s\n' '--- file status ---'
git status --short -- "$file"
git diff --stat -- "$file"Repository: openshift/release
Length of output: 35442
🏁 Script executed:
#!/bin/bash
set -eu
file='ci-operator/config/openshift/microshift/openshift-microshift-release-5.1__periodics.yaml'
printf '%s\n' '--- target cron entries ---'
rg -n '^[[:space:]]+cron:' "$file"
printf '%s\n' '--- nearby job definitions ---'
sed -n '1,360p' "$file"
printf '%s\n' '--- repository parking schedules ---'
rg -n -i 'cron:|impossible|park|disable' ci-operator/config | head -200
printf '%s\n' '--- file status ---'
git status --short -- "$file"
git diff --stat -- "$file"Repository: openshift/release
Length of output: 37752
🏁 Script executed:
#!/bin/bash
set -eu
file='ci-operator/config/openshift/microshift/openshift-microshift-release-5.1__periodics.yaml'
printf '%s\n' '--- parent revision cron entries ---'
git show "HEAD^:$file" | rg -n '^[[:space:]]+cron:' || true
printf '%s\n' '--- exact parent-to-current changes ---'
git diff --no-ext-diff --unified=3 HEAD^ -- "$file"
printf '%s\n' '--- nearby disabled-periodic examples ---'
for f in \
ci-operator/config/psalajova/test/psalajova-test-master.yaml \
ci-operator/config/insights-onprem/cost-onprem-chart/insights-onprem-cost-onprem-chart-main__periodics.yaml \
ci-operator/config/rhbk/sso-test/rhbk-sso-test-main__rhsso-product-ocp4.19-lp-interop.yaml
do
if test -f "$f"; then
printf '\n--- %s ---\n' "$f"
sed -n '1,120p' "$f"
fi
doneRepository: openshift/release
Length of output: 19346
Use an impossible cron date to disable these periodics.
0 4 * 6 1-5 runs every weekday in June. The release schedules run every Sunday, Tuesday, and Thursday in June. Replace all changed schedules with the repository parking pattern, such as 0 4 31 2 *, and run make update.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@ci-operator/config/openshift/microshift/openshift-microshift-release-5.1__periodics.yaml`
at line 56, Replace the changed periodic cron schedules, including the one shown
under the release scheduling configuration, with the repository’s
impossible-date parking pattern such as 0 4 31 2 *. Apply this consistently to
all changed schedules and run make update afterward.
Source: Learnings
|
@pacevedom: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ggiguash, pacevedom The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@ggiguash: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-merge-bot
Bot
added
the
rehearsals-ack
3 participants
Summary by CodeRabbit
openshift/releaseby restricting their schedules to June 6.