Skip to content

Disable aws-perfscale loaded-upgrade crons for non-5.0 versions - #83209

Merged
openshift-merge-bot[bot] merged 3 commits into
openshift:mainfrom
mohit-sheth:disable-non-5.0-loaded-upgrades
Aug 10, 2026
Merged

Disable aws-perfscale loaded-upgrade crons for non-5.0 versions#83209
openshift-merge-bot[bot] merged 3 commits into
openshift:mainfrom
mohit-sheth:disable-non-5.0-loaded-upgrades

Conversation

@mohit-sheth

@mohit-sheth mohit-sheth commented Aug 10, 2026

Copy link
Copy Markdown
Member

Summary

  • Remove cron schedules and set always_run: false for loaded-upgrade-120nodes and loaded-upgrade-252nodes (aws-perfscale profile) in:
    • 4.22-from-4.21 loaded-upgrade config
    • 4.23-from-4.22 loaded-upgrade config
    • 5.1-from-4.22 loaded-upgrade config
  • Only 5.0-from-4.22 loaded-upgrade crons remain active on the aws-perfscale profile
  • aws-perfscale-qe loaded-upgrade-24nodes jobs are unchanged

Summary by CodeRabbit

  • Disabled aws-perfscale loaded-upgrade cron jobs for the 4.22-from-4.21, 4.23-from-4.22, and 5.1-from-4.22 configurations.
  • Set always_run: false for the loaded-upgrade-120nodes and loaded-upgrade-252nodes jobs.
  • Kept the 5.0-from-4.22 aws-perfscale crons and aws-perfscale-qe jobs unchanged.

Remove cron schedules and set always_run: false for loaded-upgrade-120nodes
and loaded-upgrade-252nodes (aws-perfscale profile) in 4.22-from-4.21,
4.23-from-4.22, and 5.1-from-4.22 configs. The aws-perfscale-qe
loaded-upgrade-24nodes jobs are unchanged. Only 5.0-from-4.22 loaded-upgrade
crons remain active on the aws-perfscale profile.

Assisted-by: Claude
Signed-off-by: Mohit Sheth <msheth@redhat.com>
@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Walkthrough

The three AWS loaded upgrade configurations remove cron schedules from the 120-node and 252-node jobs. Each job now explicitly sets always_run: false.

Changes

Loaded upgrade scheduling

Layer / File(s) Summary
Disable scheduled execution
ci-operator/config/openshift-eng/ocp-perfscale/*loaded-upgrade-from-*.yaml
The 120-node and 252-node jobs remove their cron schedules and set always_run: false in the 4.22, 4.23, and 5.1 configurations.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The PR changes only static YAML job identifiers and scheduling fields; no Ginkgo It(), Describe(), Context(), or dynamic test-title construction appears in the changed files.
Test Structure And Quality ✅ Passed The PR changes only three YAML configuration files; it contains no Ginkgo test code, so the listed Ginkgo quality checks are not applicable.
Microshift Test Compatibility ✅ Passed The commit changes only three YAML CI configuration files and adds no Ginkgo tests or test declarations; MicroShift compatibility checks are not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The pull request changes only three CI YAML files to disable cron jobs; it adds no Ginkgo e2e tests, so SNO compatibility checks do not apply.
Topology-Aware Scheduling Compatibility ✅ Passed The diff changes only three ci-operator test-config YAML files, removing cron fields and adding always_run:false; it adds no deployment manifests, operator/controller code, or topology scheduling c...
Ote Binary Stdout Contract ✅ Passed The PR changes only three YAML scheduling files; it adds no OTE binary code, main/suite setup, or process-level stdout/logging writes.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The diff changes only three YAML job schedules; it adds no Ginkgo tests, IPv4 assumptions, or external connectivity requirements.
No-Weak-Crypto ✅ Passed The PR only changes cron and always_run fields in three YAML files; the exact diff contains no weak-crypto algorithm, custom crypto, or secret-comparison usage.
Container-Privileges ✅ Passed The PR changes only cron and always_run fields; all three parsed YAML files contain no privileged, hostPID/Network/IPC, SYS_ADMIN, root identity, or allowPrivilegeEscalation settings.
No-Sensitive-Data-In-Logs ✅ Passed The diff only adds always_run: false and test names; it adds no logging, credentials, tokens, PII, hostnames, or customer data.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes disabling loaded-upgrade cron jobs for non-5.0 AWS perfscale configurations.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 10, 2026
Assisted-by: Claude
Signed-off-by: Mohit Sheth <msheth@redhat.com>
Assisted-by: Claude
Signed-off-by: Mohit Sheth <msheth@redhat.com>
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@mohit-sheth: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-eng-ocp-perfscale-main-aws-4.22-nightly-x86-loaded-upgrade-from-4.21-loaded-upgrade-120nodes openshift-eng/ocp-perfscale presubmit Presubmit changed
pull-ci-openshift-eng-ocp-perfscale-main-aws-4.22-nightly-x86-loaded-upgrade-from-4.21-loaded-upgrade-252nodes openshift-eng/ocp-perfscale presubmit Presubmit changed
pull-ci-openshift-eng-ocp-perfscale-main-aws-4.23-nightly-x86-loaded-upgrade-from-4.22-loaded-upgrade-120nodes openshift-eng/ocp-perfscale presubmit Presubmit changed
pull-ci-openshift-eng-ocp-perfscale-main-aws-4.23-nightly-x86-loaded-upgrade-from-4.22-loaded-upgrade-252nodes openshift-eng/ocp-perfscale presubmit Presubmit changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@afcollins afcollins left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 10, 2026
@openshift-ci

openshift-ci Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afcollins, mohit-sheth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mohit-sheth

Copy link
Copy Markdown
Member Author

/pj-rehearse ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@mohit-sheth: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 10, 2026
@openshift-merge-bot
openshift-merge-bot Bot merged commit 53e3599 into openshift:main Aug 10, 2026
2 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants