Skip to content

CNF-25921: Add periodic testing for cert-manager-operator#82100

Open
sebrandon1 wants to merge 1 commit into
openshift:mainfrom
sebrandon1:cert-manager-periodics-ci
Open

CNF-25921: Add periodic testing for cert-manager-operator#82100
sebrandon1 wants to merge 1 commit into
openshift:mainfrom
sebrandon1:cert-manager-periodics-ci

Conversation

@sebrandon1

@sebrandon1 sebrandon1 commented Jul 17, 2026

Copy link
Copy Markdown
Member

Summary

  • Add a __periodics.yaml variant for cert-manager-operator master branch to provide nightly regression signal

Details

The cert-manager-operator had zero periodic test jobs. This means there was no nightly regression signal and no release-specific CI data for analytical tooling. Regressions on non-AWS platforms went undetected until someone manually triggered optional tests on a PR.

This adds 5 periodic tests running on a daily cron with staggered times:

Test Platform Credentials Cron (UTC)
e2e-operator AWS (cluster claim) Mint 04:00
e2e-operator-aws-proxy AWS (proxy) Mint 08:00
e2e-operator-azure-ovn Azure Mint 12:00
e2e-operator-azure-workload-identity Azure Manual 16:00
e2e-operator-gcp-workload-identity GCP Manual 20:00

This covers AWS, GCP, Azure, proxy environments, and both Mint and Manual credential modes on a daily cadence.

Test plan

  • make update generates expected periodic and presubmit job files
  • make checkconfig passes
  • Generated openshift-cert-manager-operator-master-periodics.yaml contains correct cron jobs

Summary by CodeRabbit

Adds the cert-manager-operator master-branch periodic CI configuration with five staggered daily e2e jobs across AWS, Azure, and GCP. The jobs cover proxy environments and Mint or Manual credential modes, providing nightly regression coverage and release-specific CI data.

Add a __periodics.yaml variant for the master branch to provide
nightly regression signal across multiple platforms and credential
modes. Previously cert-manager-operator had zero periodic jobs.

Periodic tests run on a daily cron with staggered times:
- e2e-operator (AWS, Mint) at 04:00 UTC
- e2e-operator-aws-proxy at 08:00 UTC
- e2e-operator-azure-ovn (Azure, Mint) at 12:00 UTC
- e2e-operator-azure-workload-identity (Azure, Manual) at 16:00 UTC
- e2e-operator-gcp-workload-identity (GCP, Manual) at 20:00 UTC
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 17, 2026
@openshift-ci-robot

openshift-ci-robot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

@sebrandon1: This pull request references CNF-25921 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary

  • Add a __periodics.yaml variant for cert-manager-operator master branch to provide nightly regression signal

Details

The cert-manager-operator had zero periodic test jobs. This means there was no nightly regression signal and no release-specific CI data for analytical tooling. Regressions on non-AWS platforms went undetected until someone manually triggered optional tests on a PR.

This adds 5 periodic tests running on a daily cron with staggered times:

Test Platform Credentials Cron (UTC)
e2e-operator AWS (cluster claim) Mint 04:00
e2e-operator-aws-proxy AWS (proxy) Mint 08:00
e2e-operator-azure-ovn Azure Mint 12:00
e2e-operator-azure-workload-identity Azure Manual 16:00
e2e-operator-gcp-workload-identity GCP Manual 20:00

This covers AWS, GCP, Azure, proxy environments, and both Mint and Manual credential modes on a daily cadence.

Test plan

  • make update generates expected periodic and presubmit job files
  • make checkconfig passes
  • Generated openshift-cert-manager-operator-master-periodics.yaml contains correct cron jobs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: b3ba9c0b-3eaf-4947-b497-9759645a1699

📥 Commits

Reviewing files that changed from the base of the PR and between fba1190 and 216007f.

⛔ Files ignored due to path filters (2)
  • ci-operator/jobs/openshift/cert-manager-operator/openshift-cert-manager-operator-master-periodics.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/cert-manager-operator/openshift-cert-manager-operator-master-presubmits.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (1)
  • ci-operator/config/openshift/cert-manager-operator/openshift-cert-manager-operator-master__periodics.yaml

Walkthrough

Adds periodic CI configuration for cert-manager-operator, including component image builds, bundle publishing, OCP 4.22 release settings, resource requests, and scheduled end-to-end tests across multiple cluster environments.

Changes

Cert-manager operator periodics

Layer / File(s) Summary
Build inputs and image matrix
ci-operator/config/openshift/cert-manager-operator/openshift-cert-manager-operator-master__periodics.yaml
Configures repository-based builds and produces operator, cert-manager, istio-csr, and trust-manager images from Dockerfiles.
Bundle publishing and release settings
ci-operator/config/openshift/cert-manager-operator/openshift-cert-manager-operator-master__periodics.yaml
Maps bundle and component pullspecs to pipeline images, targets the OCP 4.22 nightly multi-architecture release, and defines default resource requests.
Scheduled end-to-end validation
ci-operator/config/openshift/cert-manager-operator/openshift-cert-manager-operator-master__periodics.yaml
Adds generic, AWS, Azure, and GCP periodic e2e jobs with installation parameters, label filters, deployment readiness checks, and generated CI metadata.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

  • openshift/release#81902: Adds related cert-manager-operator periodic e2e jobs using bundle installation and deployment readiness checks.
🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: adding periodic testing for cert-manager-operator.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PASS: the PR only adds static periodic job names and label filters; no Ginkgo It/Describe/Context titles or dynamic data appear.
Test Structure And Quality ✅ Passed The PR only adds CI-operator YAML; it doesn't modify any Ginkgo test code, so the Ginkgo-specific structure/cleanup/assertion checks aren't applicable.
Microshift Test Compatibility ✅ Passed No new Ginkgo tests were added; this PR only schedules existing e2e jobs, and the changed YAML contains no MicroShift-unsafe API usage.
Single Node Openshift (Sno) Test Compatibility ✅ Passed No new Ginkgo test bodies were added; this PR only adds periodic job config, and the label filters show no explicit multi-node/SNO-incompatible assumptions.
Topology-Aware Scheduling Compatibility ✅ Passed The PR only adds CI/operator test config and generated job manifests; no workload scheduling constraints, node selectors, anti-affinity, or PDBs were introduced.
Ote Binary Stdout Contract ✅ Passed PR only adds/generated CI YAML job configs; no process-level code or stdout-writing binaries were changed.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR only schedules existing cert-manager e2e jobs; the new YAML adds no IPv4 literals or direct external URLs, and public pullspecs are pipelined.
No-Weak-Crypto ✅ Passed Changed files are ci-operator YAML only; they contain no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB, custom crypto, or secret comparisons.
Container-Privileges ✅ Passed The new periodic YAML contains no privileged, hostPID/Network/IPC, SYS_ADMIN, or allowPrivilegeEscalation settings; it uses restricted security context only.
No-Sensitive-Data-In-Logs ✅ Passed The new periodic YAML contains only job config and test commands; no passwords, tokens, PII, internal hostnames, or other sensitive values were added.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sebrandon1
Once this PR has been reviewed and has the lgtm label, please assign bharath-b-rh for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
openshift-ci Bot requested review from bharath-b-rh and swghosh July 17, 2026 18:34
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@sebrandon1: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-cert-manager-operator-master-periodics-ci-bundle-cert-manager-operator-bundle openshift/cert-manager-operator presubmit Presubmit changed
pull-ci-openshift-cert-manager-operator-master-periodics-images openshift/cert-manager-operator presubmit Presubmit changed
periodic-ci-openshift-cert-manager-operator-master-periodics-e2e-operator-azure-workload-identity N/A periodic Periodic changed
periodic-ci-openshift-cert-manager-operator-master-periodics-e2e-operator-gcp-workload-identity N/A periodic Periodic changed
periodic-ci-openshift-cert-manager-operator-master-periodics-e2e-operator-aws-proxy N/A periodic Periodic changed
periodic-ci-openshift-cert-manager-operator-master-periodics-e2e-operator-azure-ovn N/A periodic Periodic changed
periodic-ci-openshift-cert-manager-operator-master-periodics-e2e-operator N/A periodic Periodic changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@swghosh

swghosh commented Jul 20, 2026

Copy link
Copy Markdown
Member

/pj-rehearse max

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@swghosh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci

openshift-ci Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

@sebrandon1: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sebrandon1

Copy link
Copy Markdown
Member Author

/rebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants