[WIP] CNTRLPLANE-2883: Add v2 ARM64 multi-arch test jobs for AWS and Azure - #81894
[WIP] CNTRLPLANE-2883: Add v2 ARM64 multi-arch test jobs for AWS and Azure#81894georgelipceanu wants to merge 1 commit into
Conversation
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
openshift-ci-robot
added
the
jira/valid-reference
|
@georgelipceanu: This pull request references CNTRLPLANE-2883 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Skipping CI for Draft Pull Request. |
|
/hold |
openshift-ci
Bot
added
the
do-not-merge/hold
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (4)
WalkthroughAdds scheduled AWS and Azure ARM64 HyperShift v2 E2E jobs. Adds optional ChangesHyperShift v2 E2E coverage
Estimated code review effort: 2 (Simple) | ~10 minutes Mergeability Score: 🔵 Low · up to The PR adds ARM64 multi-architecture CI jobs and updates generated job definitions; it is mergeable with owner confirmation that both were regenerated together, since a mismatch could prevent the new tests from being scheduled correctly. Suggested labels: Suggested reviewers: Important Pre-merge checks failedPlease resolve all errors before merging. Addressing warnings is optional. ❌ Failed checks (1 error)
✅ Passed checks (14 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
georgelipceanu
changed the title
georgelipceanu
changed the title
|
/unhold |
openshift-ci
Bot
removed
the
do-not-merge/hold
mgencur
left a comment
mgencur
left a comment
There was a problem hiding this comment.
Hey @georgelipceanu , I'm wondering if we also want to run this periodically, maybe once in 2 weeks. The current CI configs are optional pre-submit jobs so people might trigger it very rarely (maybe only on multi-arch-related changes).
| steps: | ||
| cluster_profile: hypershift-aks | ||
| dependencies: | ||
| RELEASE_IMAGE_LATEST: release:multi-latest |
There was a problem hiding this comment.
I have checked that NODEPOOL_RELEASE_IMAGE_LATEST is not used in self-managed azure 👍
There was a problem hiding this comment.
I'm wondering if we also want to run this periodically, maybe once in 2 weeks. The current CI configs are optional pre-submit jobs so people might trigger it very rarely (maybe only on multi-arch-related changes).
I'll add this in my next set of changes 👍
| TECH_PREVIEW_NO_UPGRADE: "true" | ||
| TEST_SUITE: openshift/conformance/parallel/minimal | ||
| workflow: hypershift-aws-e2e-backuprestore | ||
| - always_run: false |
There was a problem hiding this comment.
Both of these CI configs need EXTRA_ARGS: --arch=arm64 in order to actually run arm64 nodes.
There was a problem hiding this comment.
For self managed Azure, I tried to add this like so:
- always_run: false
as: e2e-v2-azure-multi-arch
optional: true
steps:
cluster_profile: hypershift-aks
dependencies:
RELEASE_IMAGE_LATEST: release:multi-latest
env:
EXTRA_ARGS: --arch=arm64 # <-- HERE
TECH_PREVIEW_NO_UPGRADE: "true"
workflow: hypershift-azure-e2e-v2-self-managedBut after running make update it shows the following error:
glipcean@glipcean-mac release % make update
# If the Python scripts fail, use the venv/ directory to establish a Python virtual environment by running these commands:
.......
time="2026-07-27T11:51:03Z" level=info msg="Configs reloaded" duration=1.897537944s
time="2026-07-27T11:51:05Z" level=error error="failed to validate configuration openshift/hypershift/openshift-hypershift-main.yaml: Failed resolve MultiStageTestConfiguration: test/e2e-v2-azure-multi-arch: workflow/hypershift-azure-e2e-v2-self-managed: parameter \"EXTRA_ARGS\" is overridden in [test/e2e-v2-azure-multi-arch] but not declared in any step"
time="2026-07-27T11:51:05Z" level=fatal msg="error validating configuration files"
make[1]: *** [ci-operator-checkconfig] Error 1
make: *** [update] Error 2I checked what the Azure v2 workflow in ci-operator/step-registry/hypershift/azure/e2e/v2-self-managed/hypershift-azure-e2e-v2-self-managed-workflow.yaml defines:
env:
CLOUD_PROVIDER: "Azure"
HYPERSHIFT_PLATFORM: "azure"
HYPERSHIFT_NODE_COUNT: "6"
HYPERSHIFT_AZURE_LOCATION: "centralus"
AZURE_SELF_MANAGED: "true"
HYPERSHIFT_EXTERNAL_DNS_DOMAIN: "sm.hcp-sm-azure.azure.devcluster.openshift.com"
HYPERSHIFT_ETCD_STORAGE_CLASS: "managed-csi-premium-v2"This shows no EXTRA_ARGS unlike the AWS workflow (in hypershift-aws-create which is used by hypershift-aws-e2e-v2-workflow.yaml). Does Azure need a different parameter for ARM64 in the CI config, or maybe I'm not using this correctly? Or alternatively I could add this to the config myself.
There was a problem hiding this comment.
@georgelipceanu Thanks for the heads up, I was only looking at AKS where we use the hypershift-azure-create step which has the arch argument. But the v2 tests on self-managed Azure use the binary from /hypershift/bin/create-guests in the hypershift-azure-create-selfmanaged-guests chain. Maybe we need to imlement something there to allow testing of arm
There was a problem hiding this comment.
Made some changes in the hypershift PR for this v2 migration in test/e2e/v2/lifecycle/azure.go to read EXTRA_ARGS environment variable, which should allow CI to pass --arch=arm64 for multi-arch cluster creation.
Signed-off-by: George Lipceanu <glipcean@redhat.com>
bdb9014 to
3c8d5bf
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: georgelipceanu The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@georgelipceanu: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
3 participants
Description
This PR adds CI presubmit jobs for the v2 migration of the v1 ARM64 NodePool creation test that validates multi-architecture NodePool provisioning on AWS and Azure platforms as part of CNTRLPLANE-2883.
Holding until openshift/hypershift#8926 is merged.
Summary by CodeRabbit
hypershift-awsprofile, ARM64 execution,m6g.xlarge, and the AWS v2 workflow.hypershift-aksprofile, ARM64 execution, and the Azure self-managed v2 workflow.EXTRA_ARGSsupport to AWS and Azure guest-cluster creation steps.