NE-2218: Build images for haproxy 2.8 and 3.2#81286
Conversation
Build new images for HAProxy 2.8 and HAProxy 3.2. These are new images split from the router, added as a sidecar of the router pod. https://redhat.atlassian.net/browse/NE-2218
openshift-ci-robot
added
the
jira/valid-reference
|
@jcmoraisjr: This pull request references NE-2218 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (8)
📒 Files selected for processing (6)
✅ Files skipped from review due to trivial changes (2)
🚧 Files skipped from review as they are similar to previous changes (4)
WalkthroughOpenShift router CI configs add ChangesRouter HAProxy image variants
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested labels: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
openshift-ci
Bot
added
the
approved
|
/pj-rehearse pull-ci-openshift-router-release-5.0-images |
|
@gcs278: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-openshift-router-release-4.23-images |
|
@gcs278: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
There isn't any reason we need to run any of the real CI jobs - these images are no-ops, but I guess it doesn't hurt to run the verify and unit tests: /pj-rehearse pull-ci-openshift-router-release-4.23-unit |
|
@gcs278: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@gcs278: requesting more than one rehearsal in one comment is not supported. If you would like to rehearse multiple specific jobs, please separate the job names by a space in a single command. |
1 similar comment
|
@gcs278: requesting more than one rehearsal in one comment is not supported. If you would like to rehearse multiple specific jobs, please separate the job names by a space in a single command. |
|
The okd-scos jobs on master (okd-scos-e2e-aws-ovn, okd-scos-images in presubmits, and okd-scos-images in postsubmits) have |
jcmoraisjr
force-pushed
the
NE-2218-haproxy-images
branch
from
809c15b to
16c31d4
Compare
Good catch. Those files are updated via |
|
/pj-rehearse pull-ci-openshift-router-master-okd-scos-images |
|
@gcs278: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@jcmoraisjr might want to check the failure here: |
jcmoraisjr
force-pushed
the
NE-2218-haproxy-images
branch
from
16c31d4 to
4a429bc
Compare
Yea in fact I missed this one, just ran and pushed the update. |
openshift-ci
Bot
removed
the
approved
|
So I wonder if this /pj-rehearse pull-ci-openshift-router-master-okd-scos-images @jcmoraisjr if this fails to find the new HAProxy 32 RPM, maybe we should try bumping to |
|
@gcs278: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@jcmoraisjr can we try bumping okd-scos-images to 5.0 as a test? it's not finding the haproxy32 RPM as I suspected: |
|
NVM @jcmoraisjr sorry i just saw your message |
jcmoraisjr
force-pushed
the
NE-2218-haproxy-images
branch
from
4a429bc to
809c15b
Compare
It seems we cannot change its version manually without impacting other builds, so reverting the OKD related changes for now as we talked, let's followup with them and add another PR after that. |
|
[REHEARSALNOTIFIER]
A total of 62 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs. A full list of affected jobs can be found here Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
openshift-ci
Bot
added
the
approved
|
@jcmoraisjr: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
I think we can move forward while we fix the existing OKD issue. As a side note: you can post PRs with using your openshift/api development branch (jcmoraisjr/api) to vendor the FG and API to get early reviews, and early CI coverage using these new images. I do this often because the API review can be slow. You can apply the /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gcs278, jcmoraisjr The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@gcs278 Thanks for all the help with tests and reviews on this PR. I think we're good to move forward. /pj-rehearse ack
Sure that's the plan, the idea is to make this as soon as FG is merged (just missing CI) so I can rebase the API and vendor that branch having both changes - or otherwise creating another branch having both changes in case FG PR insists to fail. |
|
@jcmoraisjr: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-merge-bot
Bot
added
the
rehearsals-ack
3 participants
Build new images for HAProxy 2.8 and HAProxy 3.2. These are new images split from the router, added as a sidecar of the router pod.
https://redhat.atlassian.net/browse/NE-2218
Summary by CodeRabbit
This PR updates OpenShift CI router configuration to produce additional HAProxy-specific router image variants for HAProxy 2.8 and 3.2. It adds two new build entries wired to
images/router/haproxy28/Dockerfile.ocpandimages/router/haproxy32/Dockerfile.ocp, generating image targetshaproxy-router-haproxy28andhaproxy-router-haproxy32across the router master and supported release streams (4.23, 5.0, 5.1).It also extends the OKD SCOS router configuration (
openshift-router-master__okd-scos.yaml) to build these same HAProxy 2.8/3.2 variants for theorigin_scos-4.22base, and updates the image mirroring config (core-services/image-mirroring/openshift/mapping_origin_scos-4_22) to map the new4.22tags to the correspondingquay.io/openshift/origin-haproxy-router-haproxy28:4.22.0and...haproxy32:4.22.0images.CI workflow notes from the
openshift-ci-robot/job rehearsal include validation of Jira NE-2218 and requests to rehearse image-related jobs (notably router release image builds/verify/unit flows for 4.23 and 5.0, plus OKD SCOS images).