NO-JIRA: Update kueue-must-gather-main to 5afc0f2#2164
Conversation
Image created from 'https://github.com/openshift/kueue-operator?rev=8170131a46a821d565c7227a70e345af57f0a09d' Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
red-hat-konflux
Bot
added
approved
|
@red-hat-konflux[bot]: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
WalkthroughUpdates the ChangesMust-gather Image Digest Update
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: red-hat-konflux[bot] The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: red-hat-konflux[bot] The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@related_images.developer.json`:
- Line 8: The related image reference currently has a trailing space, which
causes the generated bundle image string to be invalid when consumed by
bundle.developer.Dockerfile. Update the image entry in
related_images.developer.json so the digest string is trimmed and contains no
trailing whitespace, and make sure any similar image values in that file are
normalized the same way.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: da427326-4b05-4430-a3db-f0377819c03c
📒 Files selected for processing (2)
related_images.developer.jsonrelated_images.json
| { | ||
| "name": "must-gather", | ||
| "image": "quay.io/redhat-user-workloads/kueue-operator-tenant/kueue-must-gather-main@sha256:e5ca8d7b17f6d7a669d19277522d004f286586f07a717812a89bdd73c54fce33 " | ||
| "image": "quay.io/redhat-user-workloads/kueue-operator-tenant/kueue-must-gather-main@sha256:5afc0f2ef01db687f550e26294901bd3d6c32b57fa68ee70dfef0c371d40a62c " |
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🟠 Major | ⚡ Quick win
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
printf '\n== File context ==\n'
git ls-files related_images.developer.json bundle.developer.Dockerfile
printf '\n-- related_images.developer.json (numbered) --\n'
cat -n related_images.developer.json
printf '\n== Search for related image consumers ==\n'
rg -n --hidden --no-ignore-vcs 'MUSTGATHER_IMAGE|related_images\.developer\.json|docker pull|jq|sed substitution|image reference' bundle.developer.Dockerfile . || true
printf '\n== JSON parse / value inspection ==\n'
python3 - <<'PY'
import json, pathlib
p = pathlib.Path("related_images.developer.json")
data = json.loads(p.read_text())
img = data.get("image")
print("repr:", repr(img))
print("endswith_space:", img.endswith(" "))
print("length:", len(img))
PYRepository: openshift/kueue-operator
Length of output: 26781
🏁 Script executed:
#!/bin/bash
set -euo pipefail
python3 - <<'PY'
import json
from pathlib import Path
p = Path("related_images.developer.json")
items = json.loads(p.read_text())
print("== raw image values ==")
for item in items:
img = item["image"]
print(item["name"], "repr:", repr(img), "endswith_space:", img.endswith(" "), "len:", len(img))
print("\n== jq -r / shell-like propagation ==")
must = next(i["image"] for i in items if i["name"] == "must-gather")
print("assigned_value_repr:", repr(must))
print("trimmed_value_repr:", repr(must.strip()))
print("changed_by_strip:", must != must.strip())
PYRepository: openshift/kueue-operator
Length of output: 1353
Remove the trailing spaces from the related image digests.
Each image value in related_images.developer.json ends with a space, so jq -r preserves it and bundle.developer.Dockerfile writes an invalid image reference into the CSV.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@related_images.developer.json` at line 8, The related image reference
currently has a trailing space, which causes the generated bundle image string
to be invalid when consumed by bundle.developer.Dockerfile. Update the image
entry in related_images.developer.json so the digest string is trimmed and
contains no trailing whitespace, and make sure any similar image values in that
file are normalized the same way.
|
@red-hat-konflux[bot]: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
1 participant
Image created from 'https://github.com/openshift/kueue-operator?rev=8170131a46a821d565c7227a70e345af57f0a09d'
This PR contains the following updates:
e5ca8d7->5afc0f2Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
To execute skipped test pipelines write comment
/ok-to-testSummary by CodeRabbit
must-gatherimage reference to a newer container digest in both developer and standard release metadata.