OCPBUGS-102156: CVE-2026-33814 - validate HTTP/2 SETTINGS in vendored x/net [4.12]

[katekeiroz-dev]

What type of PR is this?

/kind bug

What this PR does / why we need it:

Addresses CVE-2026-33814 (GO-2026-4918) in vendored golang.org/x/net v0.23.0.

The HTTP/2 client transport now calls Setting.Valid() at the start of processSettingsNoWrite (backport of https://go.dev/cl/761640). Setting.Valid() already rejects an invalid MaxFrameSize.

A full module bump is not possible on this branch:

• Upstream patched version v0.53.0 requires Go 1.25
• openshift-sustaining/net@v0.35.0-sec.3 cannot be used here: release-4.12 builds with rhel-8-release-golang-1.19-openshift-4.12, and hack/update-vendor.sh cannot run on Go 1.19

Go directive remains go 1.19.

CVE Details

CVE-2026-33814 / GO-2026-4918: HTTP/2 client availability issue when processing an invalid SETTINGS frame

• Affected: golang.org/x/net/http2 before v0.53.0
• Stdlib net/http is a separate golang-builder tracker; this PR remediates the vendored extended module

Changes

• vendor/golang.org/x/net/http2/transport.go: processSettingsNoWrite calls s.Valid() before applying settings

Upstream References

• UPSTREAM status: <carry>
• Update golang.org/x/net to v0.53.0 kubernetes/kubernetes#138561 (bumps to v0.53.0; not backportable to 4.12)
• https://go.dev/cl/761640
• Sustaining tag (not usable on 4.12): https://github.com/openshift-sustaining/net/releases/tag/v0.35.0-sec.3

Test Plan

• Go version unchanged (go 1.19)
• go build -mod=vendor of golang.org/x/net/http2 with Go 1.19.13
• Confirmed processSettingsNoWrite calls s.Valid()
• CI verify / unit tests on this PR
• QE verification after merge

Related

• Jira: OCPBUGS-102156
• Go Vuln DB: GO-2026-4918

Which issue(s) this PR fixes:

Fixes OCPBUGS-102156

Does this PR introduce a user-facing change?

Fix CVE-2026-33814 in vendored golang.org/x/net HTTP/2 client transport.

Made with Cursor

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 17dc2039-759a-41fb-9747-4919dc648c2e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci-robot]

@katekeiroz-dev: This pull request references Jira Issue OCPBUGS-102156, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.12.z) matches configured target version for branch (4.12.z)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
• release note type set to "Release Note Not Required"
• dependent bug Jira Issue OCPBUGS-102372 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
• dependent Jira Issue OCPBUGS-102372 targets the "4.13.z" version, which is one of the valid target versions: 4.13.0, 4.13.z
• bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (ocp-sustaining-admins@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

What type of PR is this?

/kind bug

What this PR does / why we need it:

Addresses CVE-2026-33814 (GO-2026-4918) in vendored golang.org/x/net v0.23.0.

The HTTP/2 client transport now calls Setting.Valid() at the start of processSettingsNoWrite (backport of https://go.dev/cl/761640). Setting.Valid() already rejects an invalid MaxFrameSize.

A full module bump is not possible on this branch:

• Upstream patched version v0.53.0 requires Go 1.25
• openshift-sustaining/net@v0.35.0-sec.3 cannot be used here: release-4.12 builds with rhel-8-release-golang-1.19-openshift-4.12, and hack/update-vendor.sh cannot run on Go 1.19

Go directive remains go 1.19.

CVE Details

CVE-2026-33814 / GO-2026-4918: HTTP/2 client availability issue when processing an invalid SETTINGS frame

• Affected: golang.org/x/net/http2 before v0.53.0
• Stdlib net/http is a separate golang-builder tracker; this PR remediates the vendored extended module

Changes

• vendor/golang.org/x/net/http2/transport.go: processSettingsNoWrite calls s.Valid() before applying settings

Upstream References

• UPSTREAM status: <carry>
• Update golang.org/x/net to v0.53.0 kubernetes/kubernetes#138561 (bumps to v0.53.0; not backportable to 4.12)
• https://go.dev/cl/761640
• Sustaining tag (not usable on 4.12): https://github.com/openshift-sustaining/net/releases/tag/v0.35.0-sec.3

Test Plan

• Go version unchanged (go 1.19)
• go build -mod=vendor of golang.org/x/net/http2 with Go 1.19.13
• Confirmed processSettingsNoWrite calls s.Valid()
• CI verify / unit tests on this PR
• QE verification after merge

Related

• Jira: OCPBUGS-102156
• Go Vuln DB: GO-2026-4918

Which issue(s) this PR fixes:

Fixes OCPBUGS-102156

Does this PR introduce a user-facing change?

Fix CVE-2026-33814 in vendored golang.org/x/net HTTP/2 client transport.

Made with Cursor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@katekeiroz-dev: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

• 885d1ea|UPSTREAM: : OCPBUGS-102156: http2: validate SETTINGS before applying them: does not specify an upstream backport in the commit message

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: katekeiroz-dev
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• DOWNSTREAM_OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[katekeiroz-dev]

/ok-to-test

[openshift-ci]

@katekeiroz-dev: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/verify	885d1ea	link	true	/test verify
ci/prow/images	885d1ea	link	true	/test images

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.