Skip to content

fix(install): increase WaitUntilAvailable timeout from 5m to 10m - #9306

Open
apahim wants to merge 1 commit into
openshift:mainfrom
apahim:fix/gke-e2e-autopilot-timeouts
Open

fix(install): increase WaitUntilAvailable timeout from 5m to 10m#9306
apahim wants to merge 1 commit into
openshift:mainfrom
apahim:fix/gke-e2e-autopilot-timeouts

Conversation

@apahim

@apahim apahim commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Problem

On GKE Autopilot clusters, the HyperShift operator deployment may take longer than 5 minutes to roll out because Autopilot needs to scale up nodes before pods can be scheduled. This causes hypershift install --wait-until-available to fail with:

failed to wait for operator deployment: client rate limiter Wait returned an error: context deadline exceeded

This is one of the root causes of the e2e-v2-gke CI flakiness:
https://prow.ci.openshift.org/job-history/gs/test-platform-results/pr-logs/directory/pull-ci-openshift-hypershift-main-e2e-v2-gke

Fix

Increase the WaitUntilAvailable context timeout from 5 minutes to 10 minutes in cmd/install/install.go. This accommodates GKE Autopilot cold-start scheduling latency without affecting non-Autopilot environments (the wait returns as soon as the deployment is available).

Related

Summary by CodeRabbit

  • Bug Fixes
    • Increased the installation wait time to up to 10 minutes, improving reliability for slower operator deployments and endpoint availability.

On GKE Autopilot clusters, the operator deployment may take longer
than 5 minutes to roll out because Autopilot needs to scale up nodes
before pods can be scheduled. This causes the hypershift install
--wait-until-available flag to fail with a context deadline exceeded
error.

Increase the timeout to 10 minutes to accommodate Autopilot cold
start scheduling latency.

Signed-off-by: Amador Pahim <apahim@redhat.com>
Commit-Message-Assisted-by: Claude (via Claude Code)
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 6d5b92ac-e8c2-45d2-a111-4f806a2dc21f

📥 Commits

Reviewing files that changed from the base of the PR and between 9ea2ca9 and 1a5c192.

📒 Files selected for processing (1)
  • cmd/install/install.go

📝 Walkthrough

Walkthrough

WaitUntilAvailable now allows 10 minutes instead of 5 minutes for operator deployment rollout and endpoint availability. The change documents the additional time required for GKE Autopilot node scaling.

Suggested reviewers: clebs, csrwng, enxebre

Mergeability Score: ⚪ Minimal · up to 1a5c1

The install wait timeout increases from 5 to 10 minutes to accommodate slower cluster scheduling while returning immediately when the deployment is ready; no actionable merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 11
✅ Passed checks (11 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: increasing the WaitUntilAvailable timeout from 5 minutes to 10 minutes.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The PR changes only the WaitUntilAvailable timeout and comments in install.go; the diff introduces no Ginkgo test declarations or test titles.
Test Structure And Quality ✅ Passed The PR changes only cmd/install/install.go, replacing a production wait timeout; the exact diff adds no Ginkgo test code or It blocks to assess.
Topology-Aware Scheduling Compatibility ✅ Passed The diff only changes WaitUntilAvailable's context timeout from 5 to 10 minutes and adds a comment; it adds no deployment manifests, controllers, or scheduling constraints.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The PR changes only a 5-minute context timeout to 10 minutes in WaitUntilAvailable; it adds no Ginkgo e2e tests or new network connectivity.
No-Weak-Crypto ✅ Passed The diff changes only the WaitUntilAvailable timeout and adds a scheduling comment; it introduces no MD5, SHA1, DES, RC4, Blowfish, ECB, custom crypto, or secret comparison.
Container-Privileges ✅ Passed The PR changes only a Go timeout from 5 to 10 minutes; it adds no container or Kubernetes manifest privilege settings.
No-Sensitive-Data-In-Logs ✅ Passed The PR adds only a timeout change and explanatory comments. It adds no logging or sensitive values; existing deployment and endpoint messages are unchanged.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot added the area/cli Indicates the PR includes changes for CLI label Aug 13, 2026
@openshift-ci

openshift-ci Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: apahim
Once this PR has been reviewed and has the lgtm label, please assign bryan-cox for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov

codecov Bot commented Aug 13, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 45.75%. Comparing base (aaaf8af) to head (1a5c192).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
cmd/install/install.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9306   +/-   ##
=======================================
  Coverage   45.75%   45.75%           
=======================================
  Files         781      781           
  Lines       97837    97837           
=======================================
  Hits        44761    44761           
  Misses      50007    50007           
  Partials     3069     3069           
Files with missing lines Coverage Δ
cmd/install/install.go 68.96% <0.00%> (ø)
Flag Coverage Δ
cmd-support 38.83% <0.00%> (ø)
cpo-hostedcontrolplane 48.08% <ø> (ø)
cpo-other 45.93% <ø> (ø)
hypershift-operator 57.00% <ø> (ø)
other 34.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bryan-cox

Copy link
Copy Markdown
Member

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 13, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aks
/test e2e-aws
/test e2e-aws-upgrade-hypershift-operator
/test e2e-kubevirt-aws-ovn-reduced
/test e2e-v2-aws
/test e2e-v2-azure-self-managed
/test e2e-v2-gke

@cwbotbot

cwbotbot commented Aug 13, 2026

Copy link
Copy Markdown

Test Results

e2e-aws

e2e-aks

@openshift-ci

openshift-ci Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

@apahim: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws 1a5c192 link true /test e2e-aws
ci/prow/e2e-v2-azure-self-managed 1a5c192 link true /test e2e-v2-azure-self-managed
ci/prow/e2e-aks 1a5c192 link true /test e2e-aks
ci/prow/e2e-v2-gke 1a5c192 link true /test e2e-v2-gke

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mehabhalodiya

Copy link
Copy Markdown
Contributor

/rebase

@github-actions

Copy link
Copy Markdown

🤖 Rebasing PR onto main: workflow run

@github-actions

Copy link
Copy Markdown

⚠️ The operation succeeded locally but the push failed. If this is a fork PR, please enable Allow edits from maintainers and retry.

@bryan-cox

Copy link
Copy Markdown
Member

/rebase

@github-actions

Copy link
Copy Markdown

🤖 Rebasing PR onto main: workflow run

@github-actions

Copy link
Copy Markdown

⚠️ The operation succeeded locally but the push failed. If this is a fork PR, please enable Allow edits from maintainers and retry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/cli Indicates the PR includes changes for CLI lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants