[release-4.20] OCPBUGS-106185: fix(upsert): add desired-state hash to detect spec field removals by muraee · Pull Request #9291 · openshift/hypershift

muraee · 2026-08-12T17:14:15Z

manual backport of #7713

DeepDerivative treats nil/empty fields as "don't care", making it impossible to detect when spec fields like nodeSelector, tolerations, or container args are explicitly removed. This has been a recurring class of bugs (e.g., OCPBUGS-65879). Add a SHA-256 hash of the desired manifest state as a lightweight annotation (~64 bytes). On each reconcile the hash is computed before metadata merging and compared against the stored value. When they differ, an update is forced — catching removals that DeepDerivative misses. This replaces the earlier full-JSON last-applied-configuration approach (PR openshift#7713) which was held due to etcd size explosion at fleet scale and security concerns from embedding Secret data in annotations. A hash has none of these costs. DeepDerivative is retained as a fallback for drift detection, and the existing label-count removal workaround is preserved since hash- based detection cannot drive three-way metadata merges. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Regenerate test fixtures for release-4.20 to include the desired-state-hash annotations added by the upsert fix. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

openshift-merge-bot · 2026-08-12T17:14:20Z

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

openshift-ci-robot · 2026-08-12T17:14:24Z

@muraee: This pull request references Jira Issue OCPBUGS-106185, which is invalid:

expected dependent Jira Issue OCPBUGS-105505 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

manual backport of #7713

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2026-08-12T17:14:30Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: b27b8e45-666f-4316-bfc1-04296ff3c6c8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

_{Comment @coderabbitai help to get the list of available commands.}

openshift-ci · 2026-08-12T17:15:00Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: muraee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [muraee]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

muraee · 2026-08-12T17:15:27Z

/jira refresh

openshift-ci-robot · 2026-08-12T17:15:34Z

@muraee: This pull request references Jira Issue OCPBUGS-106185, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.20.z) matches configured target version for branch (4.20.z)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
release note text is set and does not match the template
dependent bug Jira Issue OCPBUGS-105505 is in the state Release Pending (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-105505 targets the "4.21.z" version, which is one of the valid target versions: 4.21.0, 4.21.z
bug has dependents

Requesting review from QA contact:
/cc @ropatil010

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

…ponents fixtures Regenerate fixture files to include the new desired-state-hash annotation added by the upsert system changes. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

muraee · 2026-08-13T15:21:04Z

/verified bypass

openshift-ci-robot · 2026-08-13T15:22:00Z

@muraee: The verified label has been added.

Details

In response to this:

/verified bypass

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

mehabhalodiya · 2026-08-14T09:58:58Z

/lgtm

openshift-merge-bot · 2026-08-14T09:59:13Z

Pipeline controller notification

No second-stage tests were triggered for this PR.

This can happen when:

The changed files don't match any pipeline_run_if_changed patterns
All files match pipeline_skip_if_only_changed patterns
No pipeline-controlled jobs are defined for the release-4.20 branch

Use /test ? to see all available tests.

mehabhalodiya · 2026-08-14T14:53:38Z

/test e2e-kubevirt-aws-ovn-reduced

openshift-merge-bot · 2026-08-17T17:42:30Z

/retest-required

Remaining retests: 0 against base HEAD 3ddd15f and 2 for PR HEAD 85f1ea8 in total

openshift-ci · 2026-08-18T02:04:59Z

@muraee: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/unit	`85f1ea8`	link	unknown	`/test unit`
ci/prow/e2e-aws	`85f1ea8`	link	unknown	`/test e2e-aws`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

muraee and others added 2 commits August 12, 2026 16:50

chore(testdata): regenerate fixtures with desired-state-hash annotation

d55cb2f

Regenerate test fixtures for release-4.20 to include the desired-state-hash annotations added by the upsert fix. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 12, 2026

openshift-ci Bot added the do-not-merge/needs-area label Aug 12, 2026

openshift-ci Bot requested review from enxebre and hasueki August 12, 2026 17:14

openshift-ci Bot added the area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release label Aug 12, 2026

openshift-ci Bot added area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/needs-area labels Aug 12, 2026

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 12, 2026

openshift-ci Bot requested a review from ropatil010 August 12, 2026 17:15

fix(testdata): add desired-state-hash annotations to TestReconcileCom…

85f1ea8

…ponents fixtures Regenerate fixture files to include the new desired-state-hash annotation added by the upsert system changes. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Aug 13, 2026

openshift-ci Bot assigned mehabhalodiya Aug 14, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 14, 2026

csrwng added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Aug 17, 2026

Uh oh!

Conversation

muraee commented Aug 12, 2026

Uh oh!

openshift-merge-bot Bot commented Aug 12, 2026

Uh oh!

openshift-ci-robot commented Aug 12, 2026

Uh oh!

coderabbitai Bot commented Aug 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

openshift-ci Bot commented Aug 12, 2026

Uh oh!

muraee commented Aug 12, 2026

Uh oh!

openshift-ci-robot commented Aug 12, 2026

Uh oh!

muraee commented Aug 13, 2026

Uh oh!

openshift-ci-robot commented Aug 13, 2026

Uh oh!

mehabhalodiya commented Aug 14, 2026

Uh oh!

openshift-merge-bot Bot commented Aug 14, 2026

Uh oh!

mehabhalodiya commented Aug 14, 2026

Uh oh!

openshift-merge-bot Bot commented Aug 17, 2026

Uh oh!

openshift-ci Bot commented Aug 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

coderabbitai Bot commented Aug 12, 2026 •

edited

Loading